[17.0][PERF] stock_inventory: reduce amount of write operations #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anikeenko-viktor
force-pushed
the
17.0-stock_inventory-apply-inventory-perf
branch
from
21f20d9 to
f31897a
Compare
rousseldenis
requested changes
Jan 15, 2025
| ): | ||
| new_moves = self.env["stock.move.line"] | ||
| for quant in quant_list: | ||
| moves = record_moves.search( |
There was a problem hiding this comment.
IMHO, this should not be done in the loop.
Do it before (even before the groupby(). Then use the filter in the loop. That can increase performances massively
| ) | ||
| if len(moves) == 0: | ||
| raise ValueError(_("No move lines have been created")) | ||
| move = moves[len(moves) - 1] |
There was a problem hiding this comment.
this is more correct to get the last one:
Suggested change
| move = moves[len(moves) - 1] | |
| move = moves[-1] |
| "reference": reference, | ||
| } | ||
| ) | ||
| quant.to_do = False |
There was a problem hiding this comment.
Suggested change
| quant.to_do = False | |
| quant.update({ | |
| "to_do": False, | |
| "current_inventory": False | |
| }) |
| for adjustment, quant_list in groupby( | ||
| self, key=lambda x: x.current_inventory_id | ||
| ): | ||
| new_moves = self.env["stock.move.line"] |
There was a problem hiding this comment.
This is more correct syntaxically:
Suggested change
| new_moves = self.env["stock.move.line"] | |
| new_moves = self.env["stock.move.line"].browse() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up
_apply_inventoryby writing all new moves at once to inventory. Almost 10 times faster for my case on average.Before:
After (there's no bunch of writes anymore):
