-
-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18][MIG] stock_quant_manual_assign #2213
base: 18.0
Are you sure you want to change the base?
Conversation
* Better layout * Remove active_id dependency in some computed fields * Clean code * Refine constraint * Take into account if the current line is previously reserved before clicking on the button.
…ds + add security groups + hook
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-13.0/stock-logistics-warehouse-13.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-13-0/stock-logistics-warehouse-13-0-stock_quant_manual_assign/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-13.0/stock-logistics-warehouse-13.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-13-0/stock-logistics-warehouse-13-0-stock_quant_manual_assign/
There are cases where auto-filling of qty_done of stock move line is not desirable. e.g. you assign quants manually for some of the moves in a picking and not the others, in such case you need to go over all the moves in the picking to either remove qty_done or fill it in to proceed with the validation of the entire moves. Auto-fill behavior is also troublesome when this function is used in a manufacturing order. i.e. having qty_done of the component move live messes up the outcome of the production.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_quant_manual_assign/
Currently translated at 100.0% (31 of 31 strings) Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_quant_manual_assign Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_quant_manual_assign/fr/
0f60e09
to
8f3f803
Compare
{ | ||
"name": "Test Combo Product", | ||
"type": "combo", | ||
"combo_ids": [(6, 0, [combo_product.id])], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mav-adhoc It was a luck that this worked. combo_ids
model is product.combo
. So, change the model here above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to use type consu instead but i was getting this error: "Quants cannot be created for consumables or services."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a new property on products that allows to manage stock quantities. is_storable
field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
2458b2b
to
8fbb894
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functional review
8fbb894
to
2aab40c
Compare
@rousseldenis It's ok to merge this PR? |
e1fd1a6
to
ce70672
Compare
@mav-adhoc you need to fix tests |
ce70672
to
d7a69c5
Compare
@rousseldenis Hi! Are you sure the problem is in the tests? What i can see is that a view it is not recognizing the fields inside 'quants_lines' that is part of assign.manual.quants. I don't know why is trying to search the fields inside quant_lines (lot_id for example) in the model assign.manual.quants, when they are part of assign.manual.quants.lines. |
@rousseldenis Error fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
No description provided.