Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18][MIG] stock_quant_manual_assign #2213

Open
wants to merge 65 commits into
base: 18.0
Choose a base branch
from

Conversation

mav-adhoc
Copy link
Contributor

No description provided.

fanha99 and others added 30 commits December 5, 2024 09:07
* Better layout
* Remove active_id dependency in some computed fields
* Clean code
* Refine constraint
* Take into account if the current line is previously reserved before clicking on the button.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-13.0/stock-logistics-warehouse-13.0-stock_quant_manual_assign
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-13-0/stock-logistics-warehouse-13-0-stock_quant_manual_assign/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-13.0/stock-logistics-warehouse-13.0-stock_quant_manual_assign
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-13-0/stock-logistics-warehouse-13-0-stock_quant_manual_assign/
There are cases where auto-filling of qty_done of stock move line is not desirable.
e.g. you assign quants manually for some of the moves in a picking and not the others,
in such case you need to go over all the moves in the picking to either remove qty_done
or fill it in to proceed with the validation of the entire moves. Auto-fill behavior is
also troublesome when this function is used in a manufacturing order. i.e. having
qty_done of the component move live messes up the outcome of the production.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_quant_manual_assign
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_quant_manual_assign/
Currently translated at 100.0% (31 of 31 strings)

Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_quant_manual_assign
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_quant_manual_assign/fr/
@mav-adhoc mav-adhoc force-pushed the 18.0-mig-stock_quant_manual_assign branch 11 times, most recently from 0f60e09 to 8f3f803 Compare December 5, 2024 18:40
{
"name": "Test Combo Product",
"type": "combo",
"combo_ids": [(6, 0, [combo_product.id])],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mav-adhoc It was a luck that this worked. combo_ids model is product.combo. So, change the model here above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to use type consu instead but i was getting this error: "Quants cannot be created for consumables or services."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a new property on products that allows to manage stock quantities. is_storable field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@mav-adhoc mav-adhoc force-pushed the 18.0-mig-stock_quant_manual_assign branch 2 times, most recently from 2458b2b to 8fbb894 Compare December 6, 2024 16:14
Copy link

@luc-adhoc luc-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional review

@mav-adhoc mav-adhoc force-pushed the 18.0-mig-stock_quant_manual_assign branch from 8fbb894 to 2aab40c Compare January 27, 2025 16:47
@mav-adhoc
Copy link
Contributor Author

@rousseldenis It's ok to merge this PR?

@mav-adhoc mav-adhoc force-pushed the 18.0-mig-stock_quant_manual_assign branch 3 times, most recently from e1fd1a6 to ce70672 Compare January 29, 2025 18:34
@rousseldenis
Copy link
Contributor

@mav-adhoc you need to fix tests

@mav-adhoc mav-adhoc force-pushed the 18.0-mig-stock_quant_manual_assign branch from ce70672 to d7a69c5 Compare January 31, 2025 16:51
@mav-adhoc
Copy link
Contributor Author

@rousseldenis Hi! Are you sure the problem is in the tests? What i can see is that a view it is not recognizing the fields inside 'quants_lines' that is part of assign.manual.quants. I don't know why is trying to search the fields inside quant_lines (lot_id for example) in the model assign.manual.quants, when they are part of assign.manual.quants.lines.

@mav-adhoc
Copy link
Contributor Author

@rousseldenis Error fixed!

Copy link
Contributor

@ced-adhoc ced-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.