Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] base_tier_validation_formula: Migration to 18.0 #1028

Open
wants to merge 29 commits into
base: 18.0
Choose a base branch
from

Conversation

absal-smile
Copy link

No description provided.

AdriaGForgeFlow and others added 3 commits February 21, 2025 09:58
fixup and extend tests

[ADD] systray icon for pending reviews

[FIX] Remove python safe_eval

[ADD] base_tier_validation_formula and migration scripts

[ADD] widget domain and python expression to define reviewer in tier definition

[ADD] auto updating of systray icon counter

[ADD] validation date field

[ADD] review widget dropdown menu
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supersedes #1021

Please squash administrative commits according to https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests.

The last commit [IMP] base_tier_validation_formula: pre-commit auto fixes should be split into two commits:

  1. One for pre-commit fixes (only if running pre-commit run -a produces changes, otherwise this commit can be skipped, and the next commit will handle the migration).
  2. Another for the migration

Reference: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

If you have any questions, let me know.

TT54137
@Tecnativa

LoisRForgeFlow and others added 25 commits February 21, 2025 14:51
Currently translated at 100.0% (17 of 17 strings)

Translation: server-ux-12.0/server-ux-12.0-base_tier_validation_formula
Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_tier_validation_formula/zh_CN/
[UPD] Update base_tier_validation_formula.pot
… in tier definitions

[UPD] Update base_tier_validation_formula.pot
[UPD] Update base_tier_validation_formula.pot
[UPD] Update base_tier_validation_formula.pot
- Include context keys for avoiding mail operations overhead.
@absal-smile absal-smile force-pushed the 18.0-mig-base_tier_validation_formula branch from 8f28a1c to 6870a73 Compare February 21, 2025 13:53
@carlos-lopez-tecnativa
Copy link

@absal-smile I noticed this is your first contribution—welcome to the great OCA ecosystem! 🎉

Please remember to sign your CLA according to this guide to ensure GitHub Actions run successfully.

Thanks for your contribution! 🚀. If you have any questions, feel free to let me know.

@absal-smile
Copy link
Author

@carlos-lopez-tecnativa I am currently working at Smile and I am part of the Odoo Smile team. I would like to be included in the Smile ICLA to avoid requiring approval for every workflow individually.

@pedrobaeza
Copy link
Member

pedrobaeza commented Feb 24, 2025

@vdewulf he sent the CLA request some weeks ago. Marking the corresponding partner tag, there's an automatism for synchronizing the members of GitHub to not require GH actions approval for each commit/PR.

@carlos-lopez-tecnativa
Copy link

@absal-smile please check the CI, pre-commit has failed.

@absal-smile absal-smile force-pushed the 18.0-mig-base_tier_validation_formula branch from 6870a73 to a3cee52 Compare February 24, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.