[19.0][MIG] session_db #3413
[19.0][MIG] session_db #3413
Conversation
The upstream FilesystemSessionStore does not do that.
Retry on OperationalError exception, which we receive on database restart. Return cursor to pool when reconnecting.
There were concurrency issues in evented mode. So while I was at it, I added support for threaded mode too.
If the connection to the database fails when retrying a session operation, we end up with no cursore, which makes subsequent session operations fail. We fix this by ensuring we have cursor before any operations.
…gument 'max_lifetime'" when autovacuum gets executed. Signed-off-by: Christoph Fiehe <[email protected]>
It has been implemented.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-18.0/server-tools-18.0-session_db Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-session_db/
with the parameter "login" in `_make_postgres_uri()` it becomes impossible to log in with the configured database, as it has to have the name "user". This is because of passing the `connection_info` dict as keywords parameter into the function. But because `connection_info_for` called in `setUp()` reads the config file of odoo and there the database user is `db_user` the keyword parameter is discarded and `login` is not set. The `db_`-prefix is removed. So user and password are not applied to the uri/dsn and thus login to the database is not possible, if the database wants those parameters. When I applied this change in our internal CI of solute.de, everything worked fine afterwards. This has to be ported to 17.0 and 18.0 as well.
sbidoul
force-pushed
the
19.0-mig-session_db-sbi
branch
from
0be1123 to
b53d0a0
Compare
| "did you pass in a string instead of a list?" | ||
| ) | ||
| self._cr.execute( | ||
| "DELETE FROM http_sessions WHERE sid LIKE %s||'%%'", (identifier,) |
There was a problem hiding this comment.
This would not be correct if identifier can contain a % but I don't think that is possible?
There was a problem hiding this comment.
Looks like the identifier always has to have alphanumerical characters
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
@sbidoul your merge command was aborted due to failed check(s), which you can inspect on this commit of 19.0-ocabot-merge-pr-3413-by-sbidoul-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
This PR has the |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at f0615ae. Thanks a lot for contributing to OCA. ❤️ |
8 participants
No description provided.