[18.0][MIG] base_name_search_improved: Migration to 18.0 #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (2 of 2 strings) Translation: server-tools-9.0/server-tools-9.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-9-0/server-tools-9-0-base_name_search_improved/ca/
- Descriptor: change __openerp__.py file to __manifest__.py also update module
version from 9.0.1.0.0 to 11.0.1.0.0
- Update README using guideline
- Views: replace view tag openerp to odoo and rename files to match guideline
- Models
- update imports from openerp to odoo
- remove enconding line # -*- coding: utf-8 -*-
- update to make it compatible
- remove use of SUPERUSER_ID use sudo instead.
- rename class name to make it match with guideline.
- update methods to match api used in version 11.0
- fix pylint errors
- replace use of non exist self._model with self._name
- use `Model `is not None instead of if `Model` this becuase the last one is
a empty recordset and this one was evaluate to False and never was
patching the method.
- apply changes resquested/suggested in the PR by the reviewers.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_name_search_improved/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_name_search_improved/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_name_search_improved/
Currently translated at 100.0% (25 of 25 strings) Translation: server-tools-16.0/server-tools-16.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_name_search_improved/es/
Currently translated at 36.0% (9 of 25 strings) Translation: server-tools-16.0/server-tools-16.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_name_search_improved/it/
Currently translated at 36.0% (9 of 25 strings) Translation: server-tools-16.0/server-tools-16.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_name_search_improved/it/
Currently translated at 100.0% (25 of 25 strings) Translation: server-tools-16.0/server-tools-16.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_name_search_improved/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_name_search_improved/
When applying monkey patches, we want to skip abstract models because patching those may mess up the inheritance. An example of this is ir.model which is assigned the studio mixin using inherit = ['studio.mixin', 'ir.model']. If the mixin itself is patched, and the method is overridden once again (in, say, enterprise 15's documents_spreadsheet), the super() method called in that override is the patched version of studio.mixin rather than the override of ir.model in the base module, which is now skipped entirely.
lef-adhoc
force-pushed
the
18.0-t-43308-lef
branch
4 times, most recently
from
5fda9a2 to
ecc6179
Compare
|
This PR has the |
|
Hi @pedrobaeza , could you please check this pr? thanks in advance! |
|
/ocabot migration base_name_search_improved A review by a PSC or maintainer is missing. cc @dreispt |
dreispt
reviewed
Feb 13, 2025
| limit = limit or 0 | ||
| results = [] | ||
|
|
||
| for rec_name in all_names: |
There was a problem hiding this comment.
The comments for these two for and the following if are important to understand why this code is here, and should be kept. When the reason for a piece of code is not immediately obvious, is is helpful to have a comment hinting on the why.
There was a problem hiding this comment.
I put back the original comments in the code, is that okay?
lef-adhoc
force-pushed
the
18.0-t-43308-lef
branch
from
ecc6179 to
0230874
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated through this pr #2831