Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] base_technical_user: Migration to 18.0 #3093

Merged
merged 35 commits into from
Jan 16, 2025

Conversation

Kimkhoi3010
Copy link

@Kimkhoi3010 Kimkhoi3010 commented Oct 25, 2024

It found only 3 commits to port:

Cédric Pigeon and others added 30 commits October 15, 2024 10:53
[CHG] add name to wml tag to make override easier

[FIX] remove domain on active field
OCA Transbot updated translations from Transifex
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-12.0/server-tools-12.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-base_technical_user/
Currently translated at 100.0% (5 of 5 strings)

Translation: server-tools-12.0/server-tools-12.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-base_technical_user/pt/
Currently translated at 100.0% (5 of 5 strings)

Translation: server-tools-12.0/server-tools-12.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-base_technical_user/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-13.0/server-tools-13.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-13-0/server-tools-13-0-base_technical_user/
Currently translated at 85.7% (6 of 7 strings)

Translation: server-tools-14.0/server-tools-14.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_technical_user/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-14.0/server-tools-14.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_technical_user/
Currently translated at 54.5% (6 of 11 strings)

Translation: server-tools-14.0/server-tools-14.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_technical_user/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_technical_user/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_technical_user/
Currently translated at 100.0% (8 of 8 strings)

Translation: server-tools-16.0/server-tools-16.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_technical_user/es/
Currently translated at 100.0% (8 of 8 strings)

Translation: server-tools-16.0/server-tools-16.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_technical_user/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-17.0/server-tools-17.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-base_technical_user/
xtanuiha and others added 5 commits October 15, 2024 10:53
Currently translated at 100.0% (7 of 7 strings)

Translation: server-tools-17.0/server-tools-17.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-base_technical_user/zh_CN/
First, the company should be taken through self.env.company as user.company_id
is now the default company for the user (and not the current one).

Secondly, the actual code does not allow to do recordset.with_company(B).sudo_tech()....
as allowed_company_ids in context can be filled in with current company
(and not the one of the tech user - which is unique)
When we use use_tech(raise_if_missing=True) and the technical user (user_tech_id) is not defined on the current company, the error message who said that field is empty should be related to the active company and not related to the default user's company.
@sebalix
Copy link
Contributor

sebalix commented Jan 16, 2025

/ocabot migration base_technical_user

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 16, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 16, 2025
29 tasks
)
cls.user_tech = (
cls.env["res.users"]
.with_context(no_reset_password=True)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.with_context(no_reset_password=True)
.with_context(tracking_disable=True, no_reset_password=True)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already in the cls.env, so not needed

@sebalix
Copy link
Contributor

sebalix commented Jan 16, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-3093-by-sebalix-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 295633b into OCA:18.0 Jan 16, 2025
12 of 13 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1a42eb8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.