[18.0][MIG] auditlog: Migration to 18.0 #3054
Conversation
|
Warning, there is an issue on 17.0 resulting in some workers not implementing the correct logging. #3088 is supposed to fix it. |
|
/ocabot migration auditlog |
|
@lembregtse Can you update your branch to include #3088 which is now merged? |
|
@lembregtse any update on this ;-) |
… ones to make overridding easier
…itlog.log' model (standard 'create_date' field is used instead)
…S.txt file removed
Currently translated at 100.0% (87 of 87 strings) Translation: server-tools-17.0/server-tools-17.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-auditlog/it/
Currently translated at 100.0% (87 of 87 strings) Translation: server-tools-17.0/server-tools-17.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-auditlog/es/
Currently translated at 100.0% (87 of 87 strings) Translation: server-tools-17.0/server-tools-17.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-auditlog/sv/
Currently translated at 100.0% (87 of 87 strings) Translation: server-tools-17.0/server-tools-17.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-auditlog/zh_CN/
Currently translated at 100.0% (87 of 87 strings) Translation: server-tools-17.0/server-tools-17.0-auditlog Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-auditlog/es_AR/
lembregtse
force-pushed
the
18.0-mig-auditlog
branch
2 times, most recently
from
79799f9 to
e31bf35
Compare
|
@StefanRijnhart @mylbco FYI, I've redone the PR. I somehow missed your messages! |
|
@lembregtse thanks! There is a fixup commit involved in that last merge. This would be the right moment to squash it if you would be so kind. |
lembregtse
force-pushed
the
18.0-mig-auditlog
branch
from
e31bf35 to
cf5ebb5
Compare
When a new auditlog rule is added / modified / deleted, all workers need to be notified of the change. This is done through registry signaling. The previous code was not using the proper level of signaling resulting in workers not being aware of the changes and not implementing the correct auditlog rules, because they had only invalidated their cache and not reloaded the registry. We fix this by using the same signaling as implemented in `base_automation` which sets the the registry_invalidated field of env.registry to True to cause a full registry reload.
lembregtse
force-pushed
the
18.0-mig-auditlog
branch
from
cf5ebb5 to
a455d18
Compare
|
@StefanRijnhart misunderstood, but squashed now! |
|
@lembregtse Thanks, but now I'm confused about the message in the migration commit. |
lembregtse
force-pushed
the
18.0-mig-auditlog
branch
from
a455d18 to
07f503d
Compare
|
@StefanRijnhart my bad, I seem to have "Ctrl+R'ed" into a commit message I used back then to try (as you mentioned) something locally for Raf's fix in the other PR. I've removed the message from the commit, it was not relevant here, it was for a squash I did to fix the cron data file (removing doall and numbercall). I've changed the version number as well! |
|
if possible please merge, thanks a lot |
|
@ristecona A technical of functional review would be appreciated! |
|
@lembregtse please cherry-pick #3147 |
|
And #3137 |
|
@StefanRijnhart I've cherrypicked both commits, fascinatingly it fails in the pipeline, didn't locally. Difference seems to be the "phonenumbers" python package (I did not have it installed locally). Checking it out. |
|
It makes sense, since the phone field was excluded, with @rven changes the test-case should have failed in 17.0 as well as it normally should not log any auditlog. I added an extra "changed field" to restore the test-cases original purpose. But I do not understand why installing the phonenumbers makes any difference in how auditlog "logs" stuff. Because I believe this should have failed in 17.0 as well. |
No description provided.