Skip to content

[18.0][FIX] base_external_dbsource_mssql: convert string query to TextClause expected by sqlalchemy #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JordiMForgeFlow wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[18.0][FIX] base_external_dbsource_mssql: convert string query to TextClause expected by sqlalchemy #398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions base_external_dbsource_mssql/models/base_external_dbsource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# this is needed to generate connection string
import pymssql
import sqlalchemy
from sqlalchemy import text

from odoo import fields, models

Expand Down Expand Up @@ -34,6 +35,8 @@ def _connection_open_mssql(self):

def _execute_mssql(self, sqlquery, sqlparams, metadata):
rows, cols = list(), list()
# Convert to accepted object by sqlalchemy
sqlquery = text(sqlquery)
for record in self:
with record.connection_open() as connection:
if sqlparams is None:
Expand Down