[ADD] auth_saml: Support for unsolicited SAML requests #836
Conversation
…eful for allowing IdP to initiate
|
Hi @vincent-hatakeyama, |
- Move res_company import before res_config_settings to fix related field dependency - Apply OCA XML formatting standards to res_config_settings.xml
There was a problem hiding this comment.
Thanks for the pull request.
A couple of additional review elements:
- The pull request lacks the version tag (“[18.0]”). It should be [IMP] rather than [ADD].
- Squash/fixup your commits into a single one
- Commit title should include [IMP] rather than [FEAT] (see https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message)
I also have a question about testing this: is there a way to test this feature with keycloak?
| allow_saml_unsolicited_req = fields.Boolean( | ||
| compute="_compute_allow_saml_unsolicited", | ||
| string="Allow Unsolicited Requests", | ||
| help="Allow IdP-initiated authentication requests", | ||
| ) | ||
|
|
There was a problem hiding this comment.
Why make this a company dependent value and not a provider dependant one?
If it is company dependent, it should only be in the configuration panel.
| "allow_unsolicited": False, | ||
| "allow_unsolicited": self.allow_saml_unsolicited_req, |
There was a problem hiding this comment.
I’m not confident the company is correct at this place, I believe it might be using the superuser company instead of any company.
| @@ -0,0 +1,82 @@ | |||
| # Copyright (C) 2010-2016, 2022 XCG Consulting <http://odoo.consulting> | |||
There was a problem hiding this comment.
| # Copyright (C) 2010-2016, 2022 XCG Consulting <http://odoo.consulting> | |
| # Copyright (C) 2010-2016, 2022 XCG SAS <https://orbeet.io/> |
No need to keep the copyright unless you copied something from another test.
You should add your name or your company’s.
| <!-- Allow IdP-initiated authentication without prior AuthnRequest from SP. | ||
| Security Note: Only enable if your IdP requires unsolicited requests | ||
| and you trust the IdP to properly validate user sessions. --> |
There was a problem hiding this comment.
This should not be a comment, it should be displayed in the configuration page.
3 participants
Add configurable feature to allow unsolicited SAML requests. This is for example useful to allow IdP to initiate.