[18.0][MIG] auth_ldaps: Migration to 18.0 #833
+778
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (6 of 6 strings) Translation: server-auth-14.0/server-auth-14.0-auth_ldaps Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-auth_ldaps/it/
Currently translated at 100.0% (6 of 6 strings) Translation: server-auth-14.0/server-auth-14.0-auth_ldaps Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-auth_ldaps/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-15.0/server-auth-15.0-auth_ldaps Translate-URL: https://translation.odoo-community.org/projects/server-auth-15-0/server-auth-15-0-auth_ldaps/
BT-vstoev
suggested changes
Sep 30, 2025
|
|
||
|
|
||
| class CompanyLDAP(models.Model): | ||
| _inherit = "res.company.ldap" |
There was a problem hiding this comment.
The original model has a method def test_ldap_connection(self): that is used from a button on the form view.
Inside that method the conf is hardcoded and because of that it is missing the new keys that are introduced in this PR "is_ssl" and "skip_cert_validation". Because of that actually with this PR the button is broken (because it calls _connect with the hardcoded conf and if conf["is_ssl"] throws an error).
As a solution I would propose to add context to the button in the form, and if that context is present inside the _connect call (meaning it's a call from the button) - fill the missing conf values from self.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.