Skip to content

[16.0][IMP]Allow to configure cookie secret in the validator #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][IMP]Allow to configure cookie secret in the validator #824

wants to merge 1 commit into from

Conversation

@jesusVMayor
Copy link
Member

@jesusVMayor jesusVMayor commented Jul 17, 2025

No description provided.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jul 17, 2025

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

@jesusVMayor jesusVMayor mentioned this pull request Jul 17, 2025
Closed
sbidoul
sbidoul reviewed Jul 18, 2025
View reviewed changes
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good to me.

Could you add a test? A simple unit test on _get_jwt_cookie_secret is probably sufficient. If you want to go further, some other integration tests are in auth_jwt_demo.

@jesusVMayor jesusVMayor force-pushed the 16.0_auth_jwt_cookie_secret branch from c4970d4 to 56c6a77 Compare July 21, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbidoul sbidoul sbidoul left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jesusVMayor @OCA-git-bot @sbidoul