Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][PORT] auth_oidc: prompt for account on AAD login #706

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

CRogos
Copy link
Contributor

@CRogos CRogos commented Oct 9, 2024

cherry pick of #573

@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

@CRogos CRogos force-pushed the 17.0-port-auth_oidc-select_account branch from 5519151 to cf071ce Compare October 9, 2024 14:58
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Compared with 16.0, no functional tests.

Copy link

@MohamedOsman7 MohamedOsman7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbidoul
Copy link
Member

sbidoul commented Oct 22, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-706-by-sbidoul-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 93a97b8 into OCA:17.0 Oct 22, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e1aa479. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants