Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] password_security: Set password update date for already existin… #691

Merged

Conversation

keylor2906
Copy link
Contributor

…g users that don't have it. This fixes the password expiration date and other validations that require an existing value for password update date.

[IMP] password_security: Simplify validation on password reset.

@maneandrea
Copy link

@moylop260 , @rolandojduartem could you review when CI passes?

@keylor2906 Could you check the CI? I think there are some reformatting issues

…g users that don't have it. This fixes the password expiration date and other validations that require an existing value for password update date.

[IMP] password_security: Simplify validation on password reset.
@keylor2906 keylor2906 force-pushed the 16.0-set-password-date-dev-keylor2906 branch from 55dc82f to f178694 Compare September 18, 2024 20:53
Copy link
Contributor

@moylop260 moylop260 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maneandrea
Copy link

@moylop260 When you have time could you merge this?

@moylop260
Copy link
Contributor

/ocabot merge nobump

1 similar comment
@moylop260
Copy link
Contributor

/ocabot merge nobump

@moylop260 moylop260 merged commit dfeb26a into OCA:16.0 Sep 20, 2024
9 checks passed
@moylop260 moylop260 deleted the 16.0-set-password-date-dev-keylor2906 branch September 20, 2024 03:14
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-691-by-moylop260-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 20, 2024
Signed-off-by moylop260
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fc90688. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants