-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][ADD] impersonate_login #637
base: 14.0
Are you sure you want to change the base?
Conversation
e7334b8
to
9cfe6f4
Compare
9cfe6f4
to
84a704f
Compare
@Kev-Roche Did you already forward port this to v16/v17? |
comodel_name="res.partner", | ||
string="Impersonated Author", | ||
compute="_compute_impersonated_author_id", | ||
store=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will take forever to compute in active databases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just ALTER TABLE mail_message ADD COLUMN impersonated_author_id INTEGER;
@Kev-Roche We are working on a v17 port. Like the module. |
Hi @CasVissers-360ERP , thanks for your interest. I did not work on other versions yet because tests are missing and I m not sure if the module is working properly. |
Well the module will make our lives a lot easier. I will ask more team members to review. |
request.session.session_token = security.compute_session_token( | ||
request.session, request.env | ||
) | ||
return { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we go to a user without access to the current URL we get an access error, might be better to redirect to main menu?
@Kev-Roche Please feel free to include some of the changes I did there, for example the revised |
6218882
to
9c45742
Compare
9c45742
to
a108a9a
Compare
@CasVissers-360ERP , @astirpe thank you both for your time and help on this module, I bring some of your changes from V16/17 here. |
This module allows to login as another user, its purpose is mainly (only?) for testing and the support team.
As an alternative to auth_admin_passkey, for a more French/European data security complience.
No tests wrote in this module yet, any hints / help will be appreciated.
After adding tests, I will migrate the module in v16.