Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] auth_oauth_autologin: Migration to 16.0 #627

Merged
merged 11 commits into from
Jan 22, 2025
Merged

[MIG] auth_oauth_autologin: Migration to 16.0 #627

merged 11 commits into from
Jan 22, 2025

Conversation

benwillig
Copy link
Contributor

No description provided.

@benwillig benwillig force-pushed the 16.0-mig_auth_oauth_autologin-bwi branch from 1f280a0 to e573263 Compare March 20, 2024 14:59
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 21, 2024
@sbidoul sbidoul changed the title [MIG] auth_oauth_autlogin: Migration to 16.0 [MIG] auth_oauth_autologin: Migration to 16.0 Aug 11, 2024
@sbidoul
Copy link
Member

sbidoul commented Aug 11, 2024

/ocabot migration auth_oauth_autologin

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Aug 11, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 11, 2024
Open
22 tasks
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 11, 2024
@sbidoul
Copy link
Member

sbidoul commented Aug 11, 2024

@benwillig In the past I think we could pass a ?no_autologin to the /web/login route to prevent autologin.

This does not seem to work anymore. Maybe it's just me?

@benwillig
Copy link
Contributor Author

@sbidoul Yes no_autologin should avoid the redirection but it doesn't look to be working properly. I will take a look at it.

@CasVissers-360ERP CasVissers-360ERP mentioned this pull request Aug 23, 2024
Open
@benwillig benwillig force-pushed the 16.0-mig_auth_oauth_autologin-bwi branch from e573263 to 5df0507 Compare August 28, 2024 12:44
@benwillig
Copy link
Contributor Author

@sbidoul keep_blank_values=True was missing when parsing the query. It should work as expected now.

@CasVissers-360ERP
Copy link

Tested:
https://oca-server-auth-16-0-pr627-5df0507fe3c9.runboat.odoo-community.org/web/login?no_autologin
https://oca-server-auth-16-0-pr627-5df0507fe3c9.runboat.odoo-community.org/web/login

CasVissers-360ERP
CasVissers-360ERP approved these changes Aug 28, 2024
View reviewed changes
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 29, 2024
@sbidoul sbidoul mentioned this pull request Jan 21, 2025
Closed
@vincent-hatakeyama vincent-hatakeyama mentioned this pull request Jan 22, 2025
Closed
vincent-hatakeyama
vincent-hatakeyama approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@vincent-hatakeyama vincent-hatakeyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a server using OIDC, then deployed in production.

Works as expected.

@sbidoul
Copy link
Member

sbidoul commented Jan 22, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-627-by-sbidoul-bump-nobump, awaiting test results.

@sbidoul
Copy link
Member

sbidoul commented Jan 22, 2025

Thanks @vincent-hatakeyama !

@OCA-git-bot OCA-git-bot merged commit 02c1dad into OCA:16.0 Jan 22, 2025
6 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c84e2d2. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul deleted the 16.0-mig_auth_oauth_autologin-bwi branch January 22, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbidoul sbidoul sbidoul approved these changes

@vincent-hatakeyama vincent-hatakeyama vincent-hatakeyama approved these changes

@CasVissers-360ERP CasVissers-360ERP CasVissers-360ERP approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@benwillig @sbidoul @CasVissers-360ERP @OCA-git-bot @vincent-hatakeyama @oca-travis @rousseldenis