[MIG][16.0] Migration of vault #611

fkantelberg · 2024-02-01T21:06:23Z

The migration needed quite a rework because of the JS framework changes. (I hope the next are easier) I tested every functionality during migration but plan to do another round again soon.

There are some minor fixes which were possible to do:

Better file handling. Inside of an entry you can send files to an inbox now
Adjusting the iterations for PBKDF2 to the OWASP recommendations >= 600,000. The user keys should be automatically migrated if the user uses it the first time [backportable]

pedrobaeza · 2024-02-02T06:52:08Z

Thanks for the migration.

Can you please leave this one only for the module vault and o later vault_share with its story. Another thing you can do is to compact a bit the commit story, as it contains some non useful commits, like the first 11.

Fix website in manifest Run pre-commit Move models to own files. Apply OCA conventions Remove logging causing the tests to fail Add application icon Split models into files. Use lambda for defaults Add icon to menuitem Use lambda as suggested Add missing keepass lib Show information if user lacks public key Add note about no https Fix domain for user_id in send wizard. Add permanent note to wizard

vault_controller

…lect all possible users due to access rights - Disable the features if browser isn't using a secure context (https/localhost) - Load required assets in inbox and share frontends - Allow the user to switch a parent of an entry within the same vault - Allow to create entries for vaults using the main menu Entries - Fix bug that encrypted a share twice due to multiple extension with VaultAbstract - Fix a bug on share create that throws a warning about changed values

…changed Note about disaster recovery project Add missing dependency to base_setup for res.config.settings view

Before the path if we create a new child entry from other entry, the complte_name of the entry is not changing when we save the new entry. Doing this changes, we are getting the complete_name correctly. TT38729

vault: Searchpanel improvements: - Add a domain to only show records with children. - Set limit to False. TT38731 vault: Add Vaults to searchpanel view. TT38731

…he fields and files aren't overwritten

… Re-encrypt vaults if the user changes the private key - Recompute access. Unittests

fkantelberg · 2024-02-14T20:52:17Z

I was able to reproduce the issue. Seems like a hidden bug in all versions. I reproduced it by clicking away the first password dialog when I clean all browser caches. If I try to read this.time was null which causes an early return instead of reimporting of the keys.

CarlosRoca13 · 2024-02-15T06:42:53Z

I'm giving access to demo user but he can not see any secret... See gif below

fkantelberg · 2024-02-17T17:05:08Z

In my tests I had the issue that the key in vault.right wasn't generated correctly because of the if in the controller. I suspect that this is also the issue for your case. Not 100% sure because the right was marked red in my case but isn't in your case.

bosd · 2024-02-17T18:07:20Z

The buttons in the topbar, don't seem to be working.
Import file, Export file, Verify, Re-encrypt

Also the smart button "Entries" is no longer working.

fkantelberg · 2024-02-19T07:21:03Z

@bosd I can't reproduce it and every button is working. Maybe a module update gone wrong on your local instance? At least the smart button doesn't do anything special just uses a normal action.

CarlosRoca13 · 2024-02-19T07:33:51Z

In my tests I had the issue that the key in vault.right wasn't generated correctly because of the if in the controller. I suspect that this is also the issue for your case. Not 100% sure because the right was marked red in my case but isn't in your case.

I think the problem was that, I have deleted and re-added the user and there has been no problem.

I think it's ready 👍 😄

bosd · 2024-02-19T08:07:29Z

Maybe a module update gone wrong on your local instance?

I was using the runboat.. Will reset it and try again.

fkantelberg · 2024-02-19T08:08:35Z

@bosd Please check that you aren't using http. https:// is required for the module because the browser enforces it for the secure context and browser side encryption.

pedrobaeza · 2024-02-19T08:10:46Z

@fkantelberg maybe a clarification in the ROADMAP of the module mentioning explicitly runboat there?

bosd · 2024-02-19T08:15:29Z

Thanks,with https The import window is working now.
I'm getting more clickable icons on the screenlike in above gif's.

Export throws an error..

Viryfy buttons as well:
UncaughtPromiseError > OperationError
Uncaught Promise
OperationError

The smartbutton:

fkantelberg · 2024-02-19T08:19:55Z

There is a line in the readme This modules requires a secure context for the browser to work properly. but I guess I'm just biased and know what it means. Roadmap sounds like that I want to work on "fixing" it but http will never be supported beside localhost.

Is there a technical reason why the runboat links to http instead of the possible https per default?

@bosd
Regarding the error: I assume it just happens because it was possible to create a vault without https. The vault and user keys aren't initialized correctly and can be thrown away. I have to check if I can further prevent anything when the context isn't secured.

pedrobaeza · 2024-02-19T08:22:10Z

Roadmap sounds like that I want to work on "fixing" it but http will never be supported beside localhost.

The file is called ROADMAP.rst, but the section is "Known issues / Roadmap".

Is there a technical reason why the runboat links to http instead of the possible https per default?

@sbidoul can tell you, but if the certificate is self-signed, it's for not having the browser alert and have more questions about that.

sbidoul · 2024-02-19T08:40:24Z

Is there a technical reason why the runboat links to http instead of the possible https per default?

It's not a technical reason, but to avoid the burden of maintaining a trusted wildcard certificate.

bosd · 2024-02-19T09:46:55Z

Thanks for the clarifications.
Did'nt spot that line in the readme. Even if i did I don't know what it means 🤐

I'm used to test stuff on runboat. Did'nt occur to me that is not possible for this module.
Guess this is the exception of the rule.

fkantelberg · 2024-02-19T09:51:02Z

You can just swap to https and confirm the self signed certificate of the runboat to test it.

I understand that a wildcard cert can be a burden. I see how I can make it a bit more error prune when not using a secure context and check if I can rephrase the hint in the readme.

…d. Improve readme documentation about this requirement

fkantelberg · 2024-02-19T18:16:41Z

The latest patch does some things when the secure browser context isn't available:

Disables the buttons for vault list and form view (no create, save, discard)
Throws a descriptive error when hitting an action that https should be tried or the admin contacted

Additionally I extended the readme and added it also to the roadmap. I hope this makes it visible enough 😄

bosd

The latest patch does some things when the secure browser context isn't available:

Hehehe, That's one feature I could test succesfuly 😀

OCA-git-bot · 2024-02-20T07:35:38Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza · 2024-02-22T15:06:57Z

/ocabot merge nobump

OCA-git-bot · 2024-02-22T15:07:05Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-611-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-02-22T15:14:45Z

Congratulations, your PR was merged at 23d8df7. Thanks a lot for contributing to OCA. ❤️

fkantelberg mentioned this pull request Feb 2, 2024

Migration to version 16.0 #426

Open

22 tasks

pedrobaeza mentioned this pull request Feb 2, 2024

[WIP][MIG][16.0] vault: Migration to 16.0 #537

Closed

fkantelberg mentioned this pull request Feb 2, 2024

[MIG][16.0] Migration of vault_share #612

Merged

fkantelberg and others added 26 commits February 2, 2024 08:16

Update vault.pot

8ffcafb

Update vault_share.pot

fdfac4a

README.rst

69ba223

FIX vault: - Wrong field name

a473599

vault_controller

vault 14.0.1.5.1

4807043

Update vault.pot

d0ca265

Update vault_share.pot

3924e00

README.rst

3c93d7d

update dotfiles [ci skip]

d73d283

Prevent locking out the user from the private key when the login was …

d67eab4

…changed Note about disaster recovery project Add missing dependency to base_setup for res.config.settings view

Update vault.pot

28e4ed6

README.rst

aac9791

vault 14.0.1.6.1

f7ab44a

vault: complete_name not computed when created from other entry

743f855

Before the path if we create a new child entry from other entry, the complte_name of the entry is not changing when we save the new entry. Doing this changes, we are getting the complete_name correctly. TT38729

vault 14.0.1.6.2

2bbbab5

vault: Show just name instad of full path in searchpanel

ca99d45

vault: Searchpanel improvements: - Add a domain to only show records with children. - Set limit to False. TT38731 vault: Add Vaults to searchpanel view. TT38731

Update vault.pot

b14b431

Update vault_share.pot

4b339bf

vault_share 14.0.1.2.0

4bfaedc

vault 14.0.1.7.0

b63dbc9

Fix locking secrets because on re-encryption after removal of users t…

0a28d5c

…he fields and files aren't overwritten

vault 14.0.1.7.1

d3429a9

Allow an user to invalidate the current key if the password is lost -…

10df9e6

… Re-encrypt vaults if the user changes the private key - Recompute access. Unittests

Update vault.pot

8609227

[FIX] vault: Check against the key of vault.right

6259a60

CarlosRoca13 approved these changes Feb 19, 2024

View reviewed changes

[IMP] vault: Improve handling if no secure browser context is provide…

9f4cda0

…d. Improve readme documentation about this requirement

bosd approved these changes Feb 20, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Feb 20, 2024

OCA-git-bot added the bot is merging ⏳ label Feb 22, 2024

OCA-git-bot merged commit 2bfc1ee into OCA:16.0 Feb 22, 2024
9 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG][16.0] Migration of vault #611

[MIG][16.0] Migration of vault #611

fkantelberg commented Feb 1, 2024 •

edited

Loading

pedrobaeza commented Feb 2, 2024

fkantelberg commented Feb 14, 2024

CarlosRoca13 commented Feb 15, 2024

fkantelberg commented Feb 17, 2024

bosd commented Feb 17, 2024 •

edited

Loading

fkantelberg commented Feb 19, 2024

CarlosRoca13 commented Feb 19, 2024

bosd commented Feb 19, 2024

fkantelberg commented Feb 19, 2024

pedrobaeza commented Feb 19, 2024

bosd commented Feb 19, 2024

fkantelberg commented Feb 19, 2024

pedrobaeza commented Feb 19, 2024

sbidoul commented Feb 19, 2024

bosd commented Feb 19, 2024

fkantelberg commented Feb 19, 2024

fkantelberg commented Feb 19, 2024

bosd left a comment

OCA-git-bot commented Feb 20, 2024

pedrobaeza commented Feb 22, 2024

OCA-git-bot commented Feb 22, 2024

OCA-git-bot commented Feb 22, 2024

[MIG][16.0] Migration of vault #611

[MIG][16.0] Migration of vault #611

Conversation

fkantelberg commented Feb 1, 2024 • edited Loading

pedrobaeza commented Feb 2, 2024

fkantelberg commented Feb 14, 2024

CarlosRoca13 commented Feb 15, 2024

fkantelberg commented Feb 17, 2024

bosd commented Feb 17, 2024 • edited Loading

fkantelberg commented Feb 19, 2024

CarlosRoca13 commented Feb 19, 2024

bosd commented Feb 19, 2024

fkantelberg commented Feb 19, 2024

pedrobaeza commented Feb 19, 2024

bosd commented Feb 19, 2024

fkantelberg commented Feb 19, 2024

pedrobaeza commented Feb 19, 2024

sbidoul commented Feb 19, 2024

bosd commented Feb 19, 2024

fkantelberg commented Feb 19, 2024

fkantelberg commented Feb 19, 2024

bosd left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Feb 20, 2024

pedrobaeza commented Feb 22, 2024

OCA-git-bot commented Feb 22, 2024

OCA-git-bot commented Feb 22, 2024

fkantelberg commented Feb 1, 2024 •

edited

Loading

bosd commented Feb 17, 2024 •

edited

Loading