Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC]Add option to configure keycloak #595

Merged
merged 2 commits into from
Oct 21, 2024
Merged

[DOC]Add option to configure keycloak #595

merged 2 commits into from
Oct 21, 2024

Conversation

flotho
Copy link
Member

@flotho flotho commented Dec 23, 2023

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

sbidoul
sbidoul reviewed Dec 24, 2023
View reviewed changes
auth_oidc/readme/CONFIGURE.md Outdated
@@ -57,6 +57,7 @@ In Odoo, create a new Oauth Provider with the following parameters:
- Provider name: Keycloak (or any name you like that identify your
keycloak provider)
- Auth Flow: OpenID Connect (authorization code flow)
- Token Map : `preferred_username:user_id`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be presented as a possible alternative. sub:user_id, or email:user_id` are other common possibilities.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sbidoul , actually I added this by checking your demo datas because I didn't succeed without this option.
but you're right, other mapping are possible !

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 28, 2024
@flotho flotho requested a review from sbidoul April 28, 2024 16:59
@sbidoul
Copy link
Member

sbidoul commented Apr 29, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-595-by-sbidoul-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 29, 2024
@OCA-git-bot
Merge PR #595 into 16.0
9b3fe08 
Signed-off-by sbidoul
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 5, 2024
@sbidoul
Copy link
Member

sbidoul commented May 13, 2024

Retrying as the previous attempt was aborted due to codecov problems.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-595-by-sbidoul-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 13, 2024
@OCA-git-bot
Merge PR #595 into 16.0
ff86b05 
Signed-off-by sbidoul
@OCA-git-bot
Copy link
Contributor

@sbidoul your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-595-by-sbidoul-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sbidoul
Copy link
Member

sbidoul commented May 13, 2024

It looks like password_security tests now fail.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 15, 2024
@github-actions github-actions bot closed this Oct 20, 2024
@sbidoul sbidoul reopened this Oct 21, 2024
@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

@sbidoul
Copy link
Member

sbidoul commented Oct 21, 2024

16.0 seems to be green now, let's try again.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-595-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 559cc9f into OCA:16.0 Oct 21, 2024
16 of 17 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d5dd994. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbidoul sbidoul Awaiting requested review from sbidoul

Assignees
No one assigned
Labels
merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flotho @OCA-git-bot @sbidoul