Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] auth_api_key: allow to update api key from form view and hide … #533

Closed
wants to merge 1 commit into from

Conversation

petrus-v
Copy link

…keys in UI

While using with server auth_api_key_server_env and server_environment_data_encryption modules it makes hard to edit values for different environments.

Also I fill it's better practice to hide the key value on user interface so I've had the password="True" (I'm not considering this as security improvement but worth of it)

Copy link

github-actions bot commented Jan 7, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 7, 2024
@github-actions github-actions bot closed this Feb 11, 2024
@petrus-v
Copy link
Author

petrus-v commented Sep 5, 2024

Dear @OCA/tools-maintainers,

Is it possible to get this PR re-open and merged? it get 2 review and approved label ?

Thanks for your time

@thomaspaulb thomaspaulb reopened this Sep 5, 2024
@thomaspaulb
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-533-by-thomaspaulb-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 5, 2024
Signed-off-by thomaspaulb
@thomaspaulb thomaspaulb added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed bot is merging ⏳ stale PR/Issue without recent activity, it'll be soon closed automatically. labels Sep 5, 2024
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 814e389. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved merged 🎉 no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants