[16][MIG] auth_api_key_server_env #455 #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebalix
approved these changes
Sep 7, 2023
simahawk
reviewed
Sep 7, 2023
simahawk
requested changes
Sep 8, 2023
florian-dacosta
force-pushed
the
16.0-mig-auth_api_key_server_env
branch
from
d8d8c33
to
d45b268
Compare
|
@simahawk I have fixed pre-commit and the test + and to your comments, thanks |
simahawk
approved these changes
Sep 8, 2023
|
This PR has the |
florian-dacosta
force-pushed
the
16.0-mig-auth_api_key_server_env
branch
from
d45b268
to
c862dff
Compare
florian-dacosta
force-pushed
the
16.0-mig-auth_api_key_server_env
branch
from
c862dff
to
7857fe1
Compare
|
Food for thoughts: we might want to refactor this and the main module in favor of core /ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 864231b. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I open a new PR for this one, as last one was closed because stale.
But I believe this module is still needed, maybe a small review for past contributors/reviewers could help moving forward
@simahawk @qgroulard @yankinmax @SilvioC2C