[16.0][MIG] auth_session_timeout #507

bosd · 2023-04-20T15:24:15Z

Standard migration using odoo-module-migrator /ocabot migration auth_session_timeout .

bosd · 2023-04-20T15:47:10Z

/ocabot migration auth_session_timeout

OCA-git-bot · 2023-04-20T15:47:19Z

Sorry @bosd you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

Kaliuta · 2023-04-24T08:42:01Z

v 16.0
A message appears after a set time:
"Your Odoo session expired. The current page is about to be refreshed. "

When I click "OK", the page reloads, but I remain logged in.

bosd · 2023-05-03T13:53:16Z

A message appears after a set time: "Your Odoo session expired. The current page is about to be refreshed. "

When I click "OK", the page reloads, but I remain logged in.

I can replicate this behaviour..
Any ideas why it is not working?

Leonidas-VII · 2023-05-19T09:29:45Z

auth_session_timeout/models/res_users.py

+
+        # If session terminated, all done
+        if terminated:
+            raise SessionExpiredException("Session expired")


Hi @bosd ,

I can replicate this behaviour..
Any ideas why it is not working?

I see this line making the issue
Because you raise an exception here, then everything is reverted, the user can not log out

For solution, we should return here, not raise

@bosd please help to check, thank you

For solution, we should return here, not raise

I'm having some personal time. Later, in a couple of weeks I will get back to this.

For solution, we should return here, not raise

@Leonidas-VII Thanks for the suggestion, I made the commit. It does not seem to resolve the problem.

I have the impression it is related to these lines:

https://github.com/OCA/server-auth/pull/507/files#diff-1648a6bceb7d2da7ef9fc6326f0f894ee39f11f613d80c83ae53849fdb5698eaR51-R52

For return, we can just return anything here, nothing is done with the result. So we don't need to return the exception.

Meanwhile, the issue of a refresh not leading to an expiration I think is caused by this - can you cherry-pick it in?

just a question: why don't we add the auto-reload function after 5/10 seconds instead of clicking on the button "OK"?

… True * Add Usage section to ReadMe w/ Runbot link * `_crypt_context` now directly exposes the `CryptContext` * Change all instances of openerp to odoo * Add test coverage to IrConfigParameter * Add test coverage for res.users * Remove db from `get_session_parameters` method call * Remove deprecated skiparg for ormcache * Fix tests & lint * Switch cache to use self.cr.dbname * Fix ormcache

* Module auth_session_timeout: --------------------------- * Refactor to allow other modules to inherit and augment or override the following: ** Session expiry time (deadline) calculation ** Ignored URLs ** Final session expiry (with possibility to late-abort) * Re-ordered functionality to remove unnecessary work, as this code is called very often. * Do not expire a session if delay gets set to zero (or unset / false) * WIP * Fixed flake8 lint errors * Fixed flake8 lint errors * WIP * WIP * WIP * WIP * WIP * WIP * Module: auth-session-timeout: Refactor ResUser tests to use `unittest.mock` patching * Module: auth_session_timeout: Fixed flake8 lint errors * Module: auth_session_timeout: Fixed flake8 lint errors

…e backwards compatibility methods that were retained during v9 rework * Upgrade API and rename a few things for PEP-8 * Switch to HttpCase for tests * Switch to isolated build

… (#1070) * corrects AttributeError: 'HttpRequest' object has no attribute 'http' * updates the module version number for pull request #1070

@christophlsa

New changes for move module, clean module, apply new oca guideline and make compatible with 11.0: * Move module from oca/server-tools:10.0 to oca/server-auth:11.0 * Remove .DS_Store files, addd by mistake in early changes and not needed. * Fix error when make RPC request. Applied thanks to comment added by @christophlsa. For more information go to OCA/server-tools#1163 (review) * Update version to the first one in 11.0 * Update README to match new guideline * Remove she bang coding * Use _authenticate method instead of deprecated method check. For more information go to https://github.com/odoo/odoo/blob/11.0/odoo/http.py#L1049 * Improve auth_session_timeout method return raise SessionExpiredException exception instead of False. This will show a "session expired please reload page" message to the user. * Fix update unitet test. make then turn green and the update then to make them match with new changes - There was not getmtime() result definied in this test case, For that reason was returning a MagicMock() object, For this case their are trying to test that the session is valid, this is the same that the path of the file with session is not expired. To simulate that I just updated for the test case the getmtime() result to a value that will be greater than the delay expected: I used the current time This way when evaluationg if the sessions is expire will return False instead of TypeError: unorderable types: MagicMock() < float() The unit test still works the same and the result is without errors. * Fix plylint errors: - E302 expected 2 blank lines, - Not used variable and not valid var name. Remove e varaible since is not valid name and this one is not been used.

Currently translated at 100.0% (3 of 3 strings) Translation: server-auth-12.0/server-auth-12.0-auth_session_timeout Translate-URL: https://translation.odoo-community.org/projects/server-auth-12-0/server-auth-12-0-auth_session_timeout/pt_BR/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-13.0/server-auth-13.0-auth_session_timeout Translate-URL: https://translation.odoo-community.org/projects/server-auth-13-0/server-auth-13-0-auth_session_timeout/

Make it so session timeout doe not apply to requests to a route with auth_method="public". Forward port of OCA#258

Currently translated at 100.0% (3 of 3 strings) Translation: server-auth-14.0/server-auth-14.0-auth_session_timeout Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-auth_session_timeout/pt_BR/

OCA-git-bot · 2023-07-02T13:31:58Z

The migration issue (#426) has not been updated to reference the current pull request because a previous pull request (#524) is not closed.
Perhaps you should check that there is no duplicate work.
CC @dsolanki-initos

zuher83 · 2023-07-18T10:29:05Z

I think everything is ready now

bosd · 2023-07-19T11:52:39Z

I think everything is ready now

I still did not include the cherry pick. Will do it later this week.

thomaspaulb · 2023-07-19T11:55:55Z

When you do so, could you also check if this should be applied for 16.0 too?

…, but /web is a public route, so it does not trigger the session check but it does trigger session save, so the file mtime is updated before the second HTTP call makes the check takes place, and session is not expired

bosd · 2023-08-12T21:21:53Z

Excuse me for the delay. Cherry picks are now included.

thomaspaulb · 2023-08-16T19:35:27Z

Code approved, but it's probably good if someone still tests this on runbot once more to be sure. @KKamaa maybe you can do a sanity check here since you've been busy with the module

OCA-git-bot · 2023-08-16T19:45:51Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

auth_session_timeout/data/ir_config_parameter_data.xml

thomaspaulb · 2023-09-23T13:05:23Z

/ocabot merge nobump

OCA-git-bot · 2023-09-23T13:05:29Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-507-by-thomaspaulb-bump-nobump, awaiting test results.

OCA-git-bot · 2023-09-23T13:11:59Z

Congratulations, your PR was merged at 26d6505. Thanks a lot for contributing to OCA. ❤️

bosd · 2023-09-23T15:11:52Z

@CasVissers-360ERP It's Merged

Syncing from upstream OCA/server-auth (18.0)

bosd force-pushed the 16.0-mig-auth_session_timeout branch 2 times, most recently from 5cf96e3 to 20f76af Compare April 20, 2023 15:40

gurneyalex approved these changes Apr 21, 2023

View reviewed changes

Leonidas-VII reviewed May 19, 2023

View reviewed changes

pedrobaeza and others added 22 commits June 6, 2023 12:39

inactive_session_timeout > auth_session_timeout

15580fe

auth_session_timeout: References to old name

7d965de

Make modules uninstallable

a768a75

Rename manifest files

bdf9834

auth_session_timeout: Deprecate backwards compat + improve * Deprecat…

7fd4b87

…e backwards compatibility methods that were retained during v9 rework * Upgrade API and rename a few things for PEP-8 * Switch to HttpCase for tests * Switch to isolated build

corrects AttributeError: 'HttpRequest' object has no attribute 'http'…

9f13ba8

… (#1070) * corrects AttributeError: 'HttpRequest' object has no attribute 'http' * updates the module version number for pull request #1070

auth_session_timeout: Migration to 11.0

5230010

[12.0][MIG] auth_session_timeout

534e4ba

[MIG] auth_session_timeout: Migration to 13.0

8deeb89

[REF] pre-commit lint

9bb2408

Update translation files

d3c4a12

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-13.0/server-auth-13.0-auth_session_timeout Translate-URL: https://translation.odoo-community.org/projects/server-auth-13-0/server-auth-13-0-auth_session_timeout/

Update translation files

b2dcca8

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-13.0/server-auth-13.0-auth_session_timeout Translate-URL: https://translation.odoo-community.org/projects/server-auth-13-0/server-auth-13-0-auth_session_timeout/

[MIG] auth_session_timeout: Migration to 14.0

e9f755c

[FIX] auth_session_timeout: session timeout applies only to user

f7959b1

Make it so session timeout doe not apply to requests to a route with auth_method="public". Forward port of OCA#258

auth_session_timeout 14.0.1.0.1

dc57d93

[IMP] auth_session_timeout: black, isort

3457021

[MIG] auth_session_timeout: Migration to 15.0

916f690

thomaspaulb mentioned this pull request Jul 2, 2023

[16.0][mig] auth_session_timeout: Migration to 16.0 #524

Closed

gfcapalbo and others added 2 commits August 12, 2023 23:15

[13.0][IMP] timeout check triggered on session uid

e306bf2

thomaspaulb approved these changes Aug 16, 2023

View reviewed changes

OCA-git-bot added the approved label Aug 16, 2023

OCA-git-bot added the ready to merge label Aug 16, 2023

celm1990 reviewed Aug 30, 2023

View reviewed changes

auth_session_timeout/data/ir_config_parameter_data.xml Show resolved Hide resolved

max3903 requested a review from SMaciasOSI September 22, 2023 14:10

max3903 approved these changes Sep 22, 2023

View reviewed changes

SMaciasOSI approved these changes Sep 22, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Sep 23, 2023

OCA-git-bot merged commit 2263cda into OCA:16.0 Sep 23, 2023
6 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 23, 2023

bosd mentioned this pull request Sep 23, 2023

[16.0][IMP] auth_session_timeout adapt to use websocket instead of longpolling #555

Open

bosd deleted the 16.0-mig-auth_session_timeout branch September 23, 2023 15:12

thomaspaulb mentioned this pull request Feb 16, 2024

[14.0][FIX] auth_session_timeout: session does not expire on page refresh #535

Merged

fkantelberg mentioned this pull request Nov 15, 2024

[15.0][FIX] auth_session_timeout: Not expiring sessions #729

Open

SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024

Merge pull request OCA#507 from OCA/18.0

912fedf

Syncing from upstream OCA/server-auth (18.0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] auth_session_timeout #507

[16.0][MIG] auth_session_timeout #507

bosd commented Apr 20, 2023

bosd commented Apr 20, 2023

OCA-git-bot commented Apr 20, 2023

Kaliuta commented Apr 24, 2023

bosd commented May 3, 2023

Leonidas-VII May 19, 2023

CoraVanga May 26, 2023

bosd May 30, 2023

bosd Jun 6, 2023

thomaspaulb Jul 2, 2023

anhvu-sg Jul 18, 2023

OCA-git-bot commented Jul 2, 2023

zuher83 commented Jul 18, 2023

bosd commented Jul 19, 2023

thomaspaulb commented Jul 19, 2023

bosd commented Aug 12, 2023

thomaspaulb commented Aug 16, 2023

OCA-git-bot commented Aug 16, 2023

thomaspaulb commented Sep 23, 2023

OCA-git-bot commented Sep 23, 2023

OCA-git-bot commented Sep 23, 2023

bosd commented Sep 23, 2023

[16.0][MIG] auth_session_timeout #507

[16.0][MIG] auth_session_timeout #507

Conversation

bosd commented Apr 20, 2023

bosd commented Apr 20, 2023

OCA-git-bot commented Apr 20, 2023

Kaliuta commented Apr 24, 2023

bosd commented May 3, 2023

Leonidas-VII May 19, 2023

Choose a reason for hiding this comment

CoraVanga May 26, 2023

Choose a reason for hiding this comment

bosd May 30, 2023

Choose a reason for hiding this comment

bosd Jun 6, 2023

Choose a reason for hiding this comment

thomaspaulb Jul 2, 2023

Choose a reason for hiding this comment

anhvu-sg Jul 18, 2023

Choose a reason for hiding this comment

OCA-git-bot commented Jul 2, 2023

zuher83 commented Jul 18, 2023

bosd commented Jul 19, 2023

thomaspaulb commented Jul 19, 2023

bosd commented Aug 12, 2023

thomaspaulb commented Aug 16, 2023

OCA-git-bot commented Aug 16, 2023

thomaspaulb commented Sep 23, 2023

OCA-git-bot commented Sep 23, 2023

OCA-git-bot commented Sep 23, 2023

bosd commented Sep 23, 2023