[IMP] auth_saml nicer handling of logout and autoredirect #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurneyalex
force-pushed
the
15.0-imp-auth_saml
branch
from
9c3c078 to
11a4a3c
Compare
gurneyalex
commented
Apr 12, 2023
|
|
||
| class Session(WebSession): | ||
| @http.route("/web/session/logout", type="http", auth="none") | ||
| def logout(self, redirect="/web/login"): |
There was a problem hiding this comment.
I'm wondering if I should not just say
Suggested change
| def logout(self, redirect="/web/login"): | |
| def logout(self, redirect="/web/login?disable_autoredirect="): |
and simply return super().logout(redirect)
There was a problem hiding this comment.
hello @gurneyalex , reading the doc https://github.com/OCA/server-auth/blob/15.0/auth_saml/README.rst#configuration I think we could try to test it and have an answer
There was a problem hiding this comment.
I've tried this variant, seems we have the same expected result
When autoredirect is enabled, but some technical accounts have a normal password authentication setup, it can be difficult to access them as logging out of a session will trigger the autoredirect feature. We change this by overriding the logout redirection so that it sets the disable_autoredirect parameter -> this way the user will get redirected to the normal signin screen.
gurneyalex
force-pushed
the
15.0-imp-auth_saml
branch
from
11a4a3c to
0f552d5
Compare
yankinmax
approved these changes
Apr 18, 2023
ivantodorovich
approved these changes
Apr 18, 2023
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 7b6211f. Thanks a lot for contributing to OCA. ❤️ |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-auth
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-auth (17.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When autoredirect is enabled, but some technical accounts have a normal
password authentication setup, it can be difficult to access them as
logging out of a session will trigger the autoredirect feature.
We change this by overriding the logout redirection so that it sets the
disable_autoredirect parameter -> this way the user will get redirected
to the normal signin screen.