Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] password_security: add flag to enable/disable password security policy #500

Merged
merged 2 commits into from
Sep 23, 2023
Merged

[IMP] password_security: add flag to enable/disable password security policy #500

merged 2 commits into from
Sep 23, 2023

Conversation

ajaniszewska-dev
Copy link

@ajaniszewska-dev ajaniszewska-dev commented Mar 20, 2023 •
edited by sebalix
Loading

image
image

@ajaniszewska-dev ajaniszewska-dev force-pushed the password_sec_flag branch 2 times, most recently from a3c10d2 to f015b0e Compare March 20, 2023 14:26
@sebalix sebalix added this to the 15.0 milestone Mar 20, 2023
@sebalix sebalix changed the title [IMP] password_security: add flag to enable/disable password security… [IMP] password_security: add flag to enable/disable password security policy Mar 20, 2023
@sebalix
Copy link
Contributor

sebalix commented Mar 20, 2023

NOTE: this flag is required do not get unrelated tests failing when a user is created with a weak password.
In general I think it's better to propose an option to enable a feature if this one could break existing features/flows.

@sebalix sebalix force-pushed the password_sec_flag branch 6 times, most recently from c51b4fa to 6c1779e Compare March 23, 2023 14:49
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 23, 2023
@thomaspaulb thomaspaulb added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Jul 24, 2023
@sebalix sebalix force-pushed the password_sec_flag branch 3 times, most recently from 3ccf330 to 0efdd70 Compare September 22, 2023 07:42
@sebalix sebalix removed the no stale Use this label to prevent the automated stale action from closing this PR/Issue. label Sep 22, 2023
@sebalix
Copy link
Contributor

sebalix commented Sep 22, 2023

@ajaniszewska-dev @thomaspaulb I rebased the PR and rework a bit its content to reduce the diff to its minimum, ready for another review

simahawk
simahawk reviewed Sep 22, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration script probably needed.

password_security/models/res_company.py Show resolved Hide resolved
@thomaspaulb
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-500-by-thomaspaulb-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 05b78fb into OCA:15.0 Sep 23, 2023
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8ded2f9. Thanks a lot for contributing to OCA. ❤️

hwangh95 added a commit to twio-tech/server-auth that referenced this pull request Mar 22, 2024
@hwangh95
[MIG] password_security: Add flag to toggle password security policy
3a4d6c4 
This is a forwardported commit of OCA#500. Some portions were modified to
handle multicompany environments
hwangh95 added a commit to twio-tech/server-auth that referenced this pull request Mar 22, 2024
@hwangh95
[MIG] password_security: Add flag to toggle password security policy
1cbf189 
This is a forwardported commit of OCA#500. Some portions were modified to
handle multi-company environments
hwangh95 added a commit to twio-tech/server-auth that referenced this pull request Mar 22, 2024
@hwangh95
[MIG] password_security: Add flag to toggle password security policy
8b96e5e 
This is a forward-ported commit of OCA#500. Some portions were modified to
handle multi-company environments
@hwangh95 hwangh95 mentioned this pull request Mar 22, 2024
Closed
hwangh95 added a commit to twio-tech/server-auth that referenced this pull request Mar 22, 2024
@hwangh95
[MIG] password_security: Add flag to toggle password security policy
aff70d1 
This is a forward-ported commit of OCA#500. Some portions were modified to
handle multi-company environments
hwangh95 added a commit to twio-tech/server-auth that referenced this pull request Mar 22, 2024
@hwangh95
[MIG] password_security: Add flag to toggle password security policy
3c2d014 
This is a forward-ported commit of OCA#500. Some portions were modified to
handle multi-company environments
SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#500 from OCA/17.0
a5eed81 
Syncing from upstream OCA/server-auth (17.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebalix sebalix sebalix approved these changes

@thomaspaulb thomaspaulb thomaspaulb left review comments

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ajaniszewska-dev @sebalix @thomaspaulb @OCA-git-bot @simahawk