-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] sale_partner_address_restrict #3574
[17.0][MIG] sale_partner_address_restrict #3574
Conversation
Currently translated at 100.0% (2 of 2 strings) Translation: partner-contact-16.0/partner-contact-16.0-sale_partner_address_restrict Translate-URL: https://translation.odoo-community.org/projects/partner-contact-16-0/partner-contact-16-0-sale_partner_address_restrict/it/
7c21efb
to
bab1184
Compare
bab1184
to
d204021
Compare
@rousseldenis ready to review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional and code review 👍
@JordiMForgeFlow as an improvement, could we consider to restrict also not confirmed sales orders if setting it's enabled, or maybe is it too much restrictive? |
@AlexPForgeFlow the restriction is already covering non confirmed orders with the constrain |
@JordiMForgeFlow The constrain does not cover that if we have a draft sale order created on the system, and then we enable the setting, not being able to confirm it. I have been able to confirm sale order in that scenario. |
@AlexPForgeFlow ah I see. I don't think we should bother about previously created SOs. If they are updated then they will get the error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LGTM!
/ocabot migration sale_partner_address_restrict |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at aea6363. Thanks a lot for contributing to OCA. ❤️ |
Standard migration moving the module from partner-contact to sale-workflow
Includes improvements from #3570
Improvements: