[MIG] fastapi_auth_jwt_demo: Migration to 18.0 #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lmignon, |
kobros-tech
force-pushed
the
18.0-mig-fastapi_auth_jwt_demo
branch
from
2064f49 to
14065cc
Compare
|
@sbidoul can we review this? |
kobros-tech
force-pushed
the
18.0-mig-fastapi_auth_jwt_demo
branch
6 times, most recently
from
51e7643 to
44aa529
Compare
lmignon
requested changes
Sep 2, 2025
kobros-tech
force-pushed
the
18.0-mig-fastapi_auth_jwt_demo
branch
3 times, most recently
from
5c4a328 to
dd26e9d
Compare
|
now I see there is an issue with base_rest module js and import of js files. I saw a couple of issues, but I don't know too much about that module and it's function? |
kobros-tech
force-pushed
the
18.0-mig-fastapi_auth_jwt_demo
branch
2 times, most recently
from
b3ee9a3 to
2685d0f
Compare
kobros-tech
force-pushed
the
18.0-mig-fastapi_auth_jwt_demo
branch
from
2685d0f to
38890ef
Compare
kobros-tech
force-pushed
the
18.0-mig-fastapi_auth_jwt_demo
branch
from
38890ef to
10379e8
Compare
|
finally I fixed the issue in the other module and temporarily adding its commit here but last two commits should be deleted when we intend to merge. |
Suffexing js files with .esm.js is much better to correct style and syntax.
kobros-tech
force-pushed
the
18.0-mig-fastapi_auth_jwt_demo
branch
from
10379e8 to
023270b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.