[18.0] [MIG] migrate base_rest #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to specify a description into the services that will be used into the openapi documentation. It's not possible to use the docstring put on the service component as description since this information is lost when the final class is generated once the registery is loaded
By default in case of SessionExpiredException, Odoo return the login page with HTTP Status 200. For REST services we must return the real exception IOW 401 Unauthorize
Into the openapi documentation, declare 'id' as an integer path parameter
In HTTP GET methods, the paramters are not provided as a json document. The parameters are http query parameters. Therefore we need to translate the jsonschema defined for services available via HTTP GET into an openapi definition of the query paramters.
To avoid to redefine the generic routes in all our RestController, the routes was defined in the RestController base classe. Unfortunately even if the path into the routes was modified into the class factrory the definition of the generic routs was the same for all the Controllers inheriting from RestController. To avoid to share the definitions of these generic methods, we override the class factory into the metaclass and generate a new definition of these methods for each classes inheriting from RestController. In the same time we must also remove the RestConroller from the controller since it's an abstract controller.
In Py3 a function becomes a method only once the class def is instanciated.
…ng parser expect test
When navigating from one spec to an other, the page url is updated to include the name of the displayed page as paramter. This change takes into account this parameter when generating the swagger page to reopen the page with the selected spec open by default. In the same time, this change avoid a stacktrace when the api-docs page is called with paramters
… log level is DEBUG
Using the log level to enable the stack trace into the response is too dangerous. We must avoid to mix log level and development mode
pierre-halleux
force-pushed
the
18.0-mig-base_rest-hda
branch
from
e1f898a to
b5d2d21
Compare
pierre-halleux
changed the title
pierre-halleux
force-pushed
the
18.0-mig-base_rest-hda
branch
2 times, most recently
from
76c3f43 to
3d5982b
Compare
pierre-halleux
force-pushed
the
18.0-mig-base_rest-hda
branch
from
3d5982b to
c7f050b
Compare
2 tasks
lmignon
force-pushed
the
18.0-mig-base_rest-hda
branch
from
b4d880c to
7c939bc
Compare
|
/ocabot migration base_rest |
This was referenced Mar 19, 2025
|
Reminder to fwd port #358 (to be checked w/ oca-port). |
|
@lmignon great, thanks! We can merge if good for you 😉 |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
for sure 😁 |
|
Congratulations, your PR was merged at 2b21061. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.