Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] base_rest: show first-level menu to admins only #425

Merged
merged 1 commit into from
Feb 18, 2025
Merged

[14.0][IMP] base_rest: show first-level menu to admins only #425

merged 1 commit into from
Feb 18, 2025
+10 −4

Conversation

aleuffre
Copy link

Small self-explanatory PR.

@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

lmignon
lmignon requested changes Mar 28, 2024
View reviewed changes
base_rest/views/base_rest_view.xml
<record id="menu_rest_api_root" model="ir.ui.menu">
<field name="name">REST API</field>
<field name="sequence" eval="400" />
<field name="web_icon">base_rest,static/description/icon.png</field>
<field name="groups_id" eval="[(4, ref('base.group_system'))]" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleuffre Thank you for this proposal. Why not... but something must be set into the readme to describe how you can get access to the REST api documentation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've mentioned it in the readme as you suggested!

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 17, 2024
@lmignon
Copy link
Contributor

lmignon commented Nov 18, 2024

ping @simahawk

@lmignon lmignon added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Nov 18, 2024
@PicchiSeba PicchiSeba mentioned this pull request Nov 25, 2024
Draft
@lmignon
Copy link
Contributor

lmignon commented Feb 18, 2025

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-425-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f49aa31 into OCA:14.0 Feb 18, 2025
7 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e04bb27. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

@FrancoMaxime FrancoMaxime FrancoMaxime approved these changes

@renda-dev renda-dev renda-dev approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aleuffre @OCA-git-bot @lmignon @FrancoMaxime @renda-dev