Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] datamodel: Migration to 15.0 #222

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

yankinmax
Copy link
Contributor

No description provided.

@lmignon
Copy link
Contributor

lmignon commented Nov 24, 2021

@yankinmax No time to debug, sorry. You should take a look at #218. odoo.addons.pydantic is far more powerfull and easier than datamodel. Moreover the way I implmented the extension capabilities of an existing pydantic model is more pythonic and allows type checking. No more need to get access to a registry to retrieve a model, you simply use your pydantic class as any common python class.

Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yankinmax
Copy link
Contributor Author

@yankinmax datamodels is not declared as installable https://github.com/yankinmax/rest-framework/blob/15.0-mig-datamodel/datamodel/__manifest__.py#L19

Does it change installable to False when using the migration procedure?
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

@yankinmax yankinmax force-pushed the 15.0-mig-datamodel branch 3 times, most recently from 0c1c40b to 6279f18 Compare December 1, 2021 10:26
[UPD] rest-framework conf to include datamodel
@yankinmax
Copy link
Contributor Author

@lmignon can you pls take a look again here? It seems to be ok.

@lmignon
Copy link
Contributor

lmignon commented Dec 1, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-222-by-lmignon-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 1, 2021
Signed-off-by lmignon
@OCA-git-bot
Copy link
Contributor

@lmignon your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-222-by-lmignon-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@yankinmax
Copy link
Contributor Author

@lmignon AFAIU @simahawk restarted the build and check passed. See here OCA/server-auth#310 (comment)

@lmignon
Copy link
Contributor

lmignon commented Dec 1, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-222-by-lmignon-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit aa637a9 into OCA:15.0 Dec 1, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e87fd8d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants