-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] datamodel: Migration to 15.0 #222
Conversation
@yankinmax No time to debug, sorry. You should take a look at #218. odoo.addons.pydantic is far more powerfull and easier than datamodel. Moreover the way I implmented the extension capabilities of an existing pydantic model is more pythonic and allows type checking. No more need to get access to a registry to retrieve a model, you simply use your pydantic class as any common python class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yankinmax datamodels is not declared as installable
https://github.com/yankinmax/rest-framework/blob/15.0-mig-datamodel/datamodel/__manifest__.py#L19
Does it change installable to False when using the migration procedure? |
0c1c40b
to
6279f18
Compare
[UPD] rest-framework conf to include datamodel
6279f18
to
2781ba7
Compare
@lmignon can you pls take a look again here? It seems to be ok. |
/ocabot merge nobump |
On my way to merge this fine PR! |
@lmignon your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-222-by-lmignon-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@lmignon AFAIU @simahawk restarted the build and check passed. See here OCA/server-auth#310 (comment) |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at e87fd8d. Thanks a lot for contributing to OCA. ❤️ |
No description provided.