Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] report_wkhtmltopdf_param: Migration to 18.0 #945

Merged
merged 21 commits into from
Jan 22, 2025
Merged

[18.0][MIG] report_wkhtmltopdf_param: Migration to 18.0 #945

merged 21 commits into from
Jan 22, 2025

Conversation

LucasTran380381
Copy link

@LucasTran380381 LucasTran380381 commented Oct 25, 2024 •
edited
Loading

Change in v18:

  • replace security empty group to base.group_user
  • improve test-case: test_wkhtmltopdf_incorrect_parameter to catch warning log (OCA 18.0 not allow warning log)
  • Due to the deprecation of the _check_recursion() function in Odoo 18, the method has been renamed to _check_recursion_custom_params().

@LucasTran380381 LucasTran380381 force-pushed the 18.0-mig-report_wkhtmltopdf_param branch 2 times, most recently from 2986e0d to fd104dd Compare October 28, 2024 03:06
@LucasTran380381 LucasTran380381 marked this pull request as draft October 28, 2024 03:20
@LucasTran380381 LucasTran380381 force-pushed the 18.0-mig-report_wkhtmltopdf_param branch from 6938066 to b28a3e0 Compare October 30, 2024 04:25
@LucasTran380381 LucasTran380381 changed the title [18.0][MIG] migrate report_wkhtmltopdf_param to 18.0 [WIP] [18.0][MIG] report_wkhtmltopdf_param: Migration to 18.0 Oct 30, 2024
@LucasTran380381 LucasTran380381 force-pushed the 18.0-mig-report_wkhtmltopdf_param branch from 7e0aab9 to d8d99e1 Compare October 30, 2024 04:51
@LucasTran380381 LucasTran380381 marked this pull request as ready for review October 30, 2024 04:53
@LucasTran380381 LucasTran380381 mentioned this pull request Oct 30, 2024
Open
14 tasks
@LucasTran380381 LucasTran380381 force-pushed the 18.0-mig-report_wkhtmltopdf_param branch from d3be15c to 536f1bd Compare October 31, 2024 04:31
@CarlosRoca13
Copy link
Contributor

Thanks 4 the work 😄

Can you rebase to rebuild the runboat?

Miku Laitinen and others added 20 commits January 20, 2025 10:23
[ADD] module 'report_wkhtmltopdf_param'
6d5ff4f
@etobella
[MIG] report_wkhtmltopdf_param: Migraton to 11.0
1814458
[12.0][MIG] report_wkhtmltopdf_param
8f88f3b
@Saran440
[IMP] report_wkhtmltopdf_param: black, isort, prettier
6212787
@Saran440
[13.0][MIG] report_wkhtmltopdf_param
4a2026a
@fshah-initos
[14.0][MIG]report_wkhtmltopdf_param
7abe8d0
@yankinmax
[IMP] report_wkhtmltopdf_param: black, isort, prettier
a7c82a0
@yankinmax
[IMP] report_wkhtmltopdf_param: pylint
7a389eb
@yankinmax
[MIG] report_wkhtmltopdf_param: Migration to 15.0
f472fa8
@jabelchi
Translated using Weblate (Catalan)
59e3cfd 
Currently translated at 94.1% (16 of 17 strings)

Translation: reporting-engine-15.0/reporting-engine-15.0-report_wkhtmltopdf_param
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-15-0/reporting-engine-15-0-report_wkhtmltopdf_param/ca/
@ibuioli
Translated using Weblate (Spanish (Argentina))
4b703ea 
Currently translated at 100.0% (17 of 17 strings)

Translation: reporting-engine-15.0/reporting-engine-15.0-report_wkhtmltopdf_param
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-15-0/reporting-engine-15-0-report_wkhtmltopdf_param/es_AR/
@yankinmax
[MIG] report_wkhtmltopdf_param: Migration to 16.0
bb819c0
@weblate
Update translation files
3265545 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-16.0/reporting-engine-16.0-report_wkhtmltopdf_param
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_wkhtmltopdf_param/
@mymage
Translated using Weblate (Italian)
d71231c 
Currently translated at 47.0% (8 of 17 strings)

Translation: reporting-engine-16.0/reporting-engine-16.0-report_wkhtmltopdf_param
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_wkhtmltopdf_param/it/
@sysadminmatmoz
Translated using Weblate (Slovenian)
d03dc37 
Currently translated at 47.0% (8 of 17 strings)

Translation: reporting-engine-16.0/reporting-engine-16.0-report_wkhtmltopdf_param
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_wkhtmltopdf_param/sl/
@Ivorra78
Translated using Weblate (Spanish)
24a297b 
Currently translated at 100.0% (17 of 17 strings)

Translation: reporting-engine-16.0/reporting-engine-16.0-report_wkhtmltopdf_param
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_wkhtmltopdf_param/es/
@mymage
Translated using Weblate (Italian)
b73fff8 
Currently translated at 88.2% (15 of 17 strings)

Translation: reporting-engine-16.0/reporting-engine-16.0-report_wkhtmltopdf_param
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_wkhtmltopdf_param/it/
@trisdoan
[IMP] report_wkhtmltopdf_param: pre-commit auto fixes
c0b9d92
@trisdoan
[MIG] report_wkhtmltopdf_param: Migration to 17.0
b7de9ce
@jakobkrabbe
Translated using Weblate (Swedish)
dc0e880 
Currently translated at 100.0% (16 of 16 strings)

Translation: reporting-engine-17.0/reporting-engine-17.0-report_wkhtmltopdf_param
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-report_wkhtmltopdf_param/sv/
@LucasTran380381 LucasTran380381 force-pushed the 18.0-mig-report_wkhtmltopdf_param branch from 536f1bd to 8e13d2b Compare January 20, 2025 03:23
@LucasTran380381
Copy link
Author

Thanks 4 the work 😄

Can you rebase to rebuild the runboat?

rebased and rebuild runboat

CarlosRoca13
CarlosRoca13 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@CarlosRoca13
Copy link
Contributor

ping @victoralmau

victoralmau
victoralmau approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-945-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5578d42. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 4af38e7 into OCA:18.0 Jan 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes

@victoralmau victoralmau victoralmau approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.