[18.0][MIG] report_qweb_parameter: Migration to 18.0 #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If reusing existing records, there's the risk of conflicting tests, like modifying the VAT for the existing company and that company having a country with VAT check. We avoid it creating a new company instead.
…@T-raw WARNING devel odoo.addons.base.models.ir_qweb: Found deprecated directive @T-raw='docs.env["ir.qweb"].check_length(docs[0].vat, 10, False)[:10]' in template 237. Replace by @t-out, and explicitely wrap content in `Markup` if necessary (which likely is not the case) WARNING devel odoo.addons.base.models.ir_qweb: Found deprecated directive @T-raw='docs.env["ir.qweb"].check_length(docs[0].company_registry, False, 10)' in template 237. Replace by @t-out, and explicitely wrap content in `Markup` if necessary (which likely is not the case)
Execute pre-commit to remove the existing warning. WARNING prod py.warnings: /opt/odoo/custom/src/odoo/odoo/addons/base/models/ir_module.py:178: DeprecationWarning: XML declarations in HTML module descriptions are deprecated since Odoo 17, report_qweb_parameter can just have a UTF8 description with not need for a declaration.
xaviedoanhduy
suggested changes
Nov 10, 2024
|
Hi @ramiadavid please add this commit: |
ramiadavid
force-pushed
the
18.0-mig-report_qweb_parameter
branch
from
df665c2 to
fae20e5
Compare
done |
ramiadavid
force-pushed
the
18.0-mig-report_qweb_parameter
branch
from
fae20e5 to
34729b9
Compare
ramiadavid
force-pushed
the
18.0-mig-report_qweb_parameter
branch
from
34729b9 to
ff0fbe8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
xaviedoanhduy
approved these changes
Jan 24, 2025
| ) | ||
| if max_length and len(value) > max_length: | ||
| raise ValidationError( | ||
| self.env._("Length cannot be more than %s") % str(max_length) |
There was a problem hiding this comment.
Suggested change
| self.env._("Length cannot be more than %s") % str(max_length) | |
| self.env._("Length cannot be more than %s", max_length) |
| """No use staticmethod because self is needed to translate exception messages""" | ||
| if min_length and len(value) < min_length: | ||
| raise ValidationError( | ||
| self.env._("Length cannot be less than %s") % str(min_length) |
There was a problem hiding this comment.
Suggested change
| self.env._("Length cannot be less than %s") % str(min_length) | |
| self.env._("Length cannot be less than %s", min_length) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.