[17.0] [MIG] report_py3o: Migration to 17.0 #931
Conversation
Replace README.md by README.rst (not finished)
Remove <data> in views Protect import of py3o libs Remove dep on base module Other small changes
Rename __openerp__.py to __manifest__.py
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-16.0/reporting-engine-16.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_py3o/
Currently translated at 100.0% (46 of 46 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_py3o/es/
Currently translated at 100.0% (46 of 46 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_py3o/es_AR/
Currently translated at 17.3% (8 of 46 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_py3o/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-16.0/reporting-engine-16.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_py3o/
Signed-off-by: fazledyn-or <[email protected]>
Signed-off-by: fazledyn-or <[email protected]>
Currently translated at 100.0% (46 of 46 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_py3o/it/
Currently translated at 100.0% (46 of 46 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_py3o/sv/
report_py3o/__manifest__.py
Outdated
| "depends": ["web"], | ||
| "external_dependencies": { | ||
| "python": ["py3o.template", "py3o.formats"], | ||
| "deb": ["libreoffice"], |
There was a problem hiding this comment.
| "deb": ["libreoffice"], | |
| "bin": ["libreoffice"], |
I think this should be changed on all versions... and other modules...
There was a problem hiding this comment.
odoo docs are pretty clear on this. Nice catch.
There was a problem hiding this comment.
Umm... looks like OCA "unofficial" way (i don't know where is documented) to handle dependencies in CI env: https://github.com/OCA/oca-ci/blob/c10c90835d3baf6576faaae03f593099b9995009/bin/oca_install_addons#L16
Perhaps a solution could be to use bin to have the Odoo check and deb to indicate how to install the package with the 'apt package manager'?
ping @sbidoul
There was a problem hiding this comment.
You can add bin if you want, but please keep deb so libreoffice is installed in ci and runboat.
That said, I'm not sure libreoffice is a hard dependency. IIRC it's optional when using report_py3o_fusion_server, so in that case we should not add bin.
There was a problem hiding this comment.
@bug2point0 I think there should be both “bin” and “deb”.
As I see it, actually it all depends on which module you give more importance to 'report_py3o_fusion_server' vs 'report_py3o'... Everything else is a mess of dependencies (if you choose X with Y but you have Z then disable W... :/). At least from what I could see.
You decide, if you choose only “deb” it seems right to me... and if you choose “bin” and “deb” the same. Little more I can say.
Co-authored-by: Alexandre Díaz <[email protected]>
|
I think I've found an issue. There is a demo report for res.users model that is defined in the file 'demo/res_users_report_py3o.xml'. However, it is not added in the 'demo' section of the '__manifest__.py' but rather in 'data'. Therefore, it is always installed even if demos are not required for the module. |
No description provided.