[19.0] [MIG] queue_job: migrate + tests #840

tishmen · 2025-10-01T16:03:37Z

Scope

queue_job, test_queue_job only

Summary

Migrate to Odoo 19 using the working feature branch code.
Tests create their own users (no demo data), context handling aligned with 19.0.
Asset paths are relative under web.assets_backend.

Pre-commit

Verified locally; no additional changes applied here to keep parity with the feature branch.

Tests

Command:
./odoo/odoo-bin -c odoo.conf -d odoo_queue_pr_queue_job_base_001 --init queue_job,test_queue_job --test-tags="/queue_job,/test_queue_job" --stop-after-init
Result: all tests green locally.

Scope: queue_job, test_queue_job only

…tallable)

…config.yaml excluded-addons update\n- Prettier reformat XML/JS/SCSS and pyproject changes\n- Fix ruff UP031 in controllers and job repr/exception

…._ in controller\n- Use self.env._ + lazy %% formatting in models\n- Paginate channel search in autovacuum\n- Avoid raise in unlink; skip root channel\n- Fix tests: avoid search([]) and correct pylint disable id

sbidoul · 2025-10-01T21:24:17Z

/ocabot migration queue_job

sbidoul · 2025-10-01T21:24:45Z

/ocabot migration test_queue_job

hoangtrann

appreciate all the work you done here! please review the comments since I notice many weird comments and many changes should be in another PR instead of a migration one

queue_job/controllers/main.py

queue_job/fields.py

queue_job/job.py

queue_job/views/queue_job_views.xml

test_queue_job/tests/test_job.py

test_queue_job/tests/test_json_field.py

… error messages; keep logging/i18n/SQL intact

…(guard remains in ondelete)

…where appropriate

…ncer (#no-search-all)

…locally (#no-search-all)

…hannel model

…/-7d/-30d) per core v19 behavior

…Users)\n\n- Places the privilege below typical user/security items (e.g., OAuth providers at 30)\n- Functional change limited to security.xml data\n- pre-commit: all hooks pass locally

tishmen · 2025-10-04T23:31:27Z

@hoangtrann quick update:

We’re down to just 3 open comments on this PR; the rest are addressed and pushed.
When you have a moment, a fresh check would be super helpful.

I’d also really appreciate it if you could take a look at PR #842—specifically the tests:

You can run the suite locally with (use any throwaway DB name in place of <DB_NAME>):

./odoo/odoo-bin -c odoo.conf -d <DB_NAME>
--init queue_job,queue_job_batch,queue_job_cron,queue_job_cron_jobrunner,queue_job_subscribe,test_queue_job,test_queue_job_batch
--test-tags="/queue_job,/queue_job_batch,/queue_job_cron,/queue_job_cron_jobrunner,/queue_job_subscribe,/test_queue_job,/test_queue_job_batch"
--stop-after-init

Thanks again for the thorough and detailed review—really grateful for your contributions and feedback 🙏

queue_job/jobrunner/__init__.py

queue_job/tests/common.py

queue_job/models/queue_job.py

hoangtrann

there are still some comments stating odoo 19 scattered across the changes which I thing we should removed.

for anyone comes after these are removed, I think it's good to just summarized the major changes to the description of the pr which can also works as a good resource for reference in other mig pr

queue_job/jobrunner/__init__.py

hoangtrann · 2025-10-06T04:50:32Z

queue_job/models/base.py

+        # carry over wrapper attributes (name, doc, etc.)
+        wrapped = functools.update_wrapper(method, origin)
+        # propagate common decorator metadata used by the framework
+        for attr in (
+            "_constrains",
+            "_depends",
+            "_onchange",
+            "_ondelete",
+            "_api_model",
+            "_api_private",
+        ):
+            if hasattr(origin, attr):
+                setattr(wrapped, attr, getattr(origin, attr))


I don't know what the best to do here, but hard coding a list of apis here also don't work as a proper propagation. because if there is another api being added through customization, it will be skipped by this implementation I think 🤔

Comment-only cleanup; no functional changes.

…iate variables Address review nit: split complex f-strings into clearer parts; no functional change.

tishmen · 2025-10-11T13:18:06Z

there are still some comments stating odoo 19 scattered across the changes which I thing we should removed.

for anyone comes after these are removed, I think it's good to just summarized the major changes to the description of the pr which can also works as a good resource for reference in other mig pr

Resolved in: d27f83d

…ssing Drop flat options merge; config-only change per review guidance.

Align with review: create_index already checks existence; no functional change.

…register_hook; fix auto-delay wrapper - Remove unused `_patch_method` from Base per review - Update docstring example to patch methods in `_register_hook` - Adjust test models to patch using `functools.update_wrapper` - Fix auto-delay wrapper to store unbound origin and bind at call time Functional change limited to patching helper/tests; no manifest changes.

hoangtrann

LGTM 👍

richard-willdooit · 2025-10-21T06:34:58Z

From my checks and tests, this is all ready to go. Can it be merged?

@sbidoul

PieterPaulussen · 2025-10-27T07:59:34Z

@tishmen have you tested this version with the preforkserver configuration (using --workers=4)? Jobs are enqueued, but never started.
The threaded server setup does work.

Additionally, there is an error due to the upstream config refactoring in this method:
https://github.com/tishmen/queue/blob/pr/queue_job_base/queue_job/jobrunner/runner.py#L474-L479. On the line db_names = config["db_name"].split(",") specifically: config["db_name"] is no longer a comma separated string, but already a list so the split can be omitted.

PieterPaulussen · 2025-10-27T10:33:26Z

@tishmen An additional refactoring is necessary here because read_group is no longer supported by the core. You'll have to refactor this into the use of the new _read_group method.

nilshamerlinck · 2025-10-28T08:35:14Z

@PieterPaulussen fyi, workers mode working fine here, is the runner starting properly on your end?

PieterPaulussen

@tishmen Thanks for your effort on this. On the whole, this PR does the trick, but there are a lot of additional changes that are not essential to the module migration. In my opinion, you will get faster approvals if you slim down the changes to the bare minimum given the complexity of this module.

If you want to keep the translations in this PR, can we go one step further and use positional arguments for all translated string variables? This results in more flexibility for other languages during translating.

On the refactoring of the tests to remove the reliance on the demo_user, I would beg to differ. Unittests should rely on the presence of the demo data, just as the core does.

Finally, I would like to stress the following issue that I encountered during a local test with your code: #840 (comment)
The jobrunner does not seem to enqueue AND process the queue jobs when running is preforked server configuration. This issue should be addressed first.

PieterPaulussen · 2025-10-28T22:14:03Z

queue_job/models/queue_job.py

+        uuids = [uuid for uuid in self.mapped("graph_uuid") if uuid]
+        ids_per_graph_uuid = {}
+        if uuids:


Suggested change

uuids = [uuid for uuid in self.mapped("graph_uuid") if uuid]

ids_per_graph_uuid = {}

if uuids:

ids_per_graph_uuid = {}

if any(self.mapped("graph_uuid")):

Isn't any faster in this case?

queue_job/tests/test_json_field.py

PieterPaulussen · 2025-10-28T22:31:28Z

queue_job/tests/test_json_field.py

+                "company_ids": [(6, 0, [main_company.id])],
+                "group_ids": [(6, 0, [group_user.id])],


This should be replaced by Command.set() to be consistent with the rest of your PR.

PieterPaulussen · 2025-10-28T22:34:52Z

queue_job/tests/test_json_field.py

+        User = cls.env["res.users"]
+        main_company = cls.env.ref("base.main_company")
+        group_user = cls.env.ref("base.group_user")
+        cls.demo_user = User.create(


Suggested change

User = cls.env["res.users"]

main_company = cls.env.ref("base.main_company")

group_user = cls.env.ref("base.group_user")

cls.demo_user = User.create(

main_company = cls.env.ref("base.main_company")

group_user = cls.env.ref("base.group_user")

cls.demo_user = cls.env["res.users"].create(

A bit opnionated, but the User variable is unnecessary and Camel cased variables should not be used.

Camelcase is ok in this case as cls.env["res.users"] is (roughly) a class.

PieterPaulussen · 2025-10-28T22:36:25Z

queue_job/tests/test_json_field.py

    def test_decoder_recordset_list_without_user(self):
        value_json = (
-            '["a", 1, {"_type": "odoo_recordset",' '"model": "res.users", "ids": [1]}]'
+            '["a", 1, {"_type": "odoo_recordset","model": "res.users", "ids": [1]}]'


Suggested change

'["a", 1, {"_type": "odoo_recordset","model": "res.users", "ids": [1]}]'

'["a", 1, {"_type": "odoo_recordset", "model": "res.users", "ids": [1]}]'

PieterPaulussen · 2025-10-28T22:47:18Z

test_queue_job/tests/test_job.py

+                "company_ids": [(6, 0, [main_company.id])],
+                "group_ids": [(6, 0, [group_user.id])],


Should be replaced by Command.set()

PieterPaulussen · 2025-10-28T22:47:44Z

test_queue_job/tests/test_job.py

+                "company_ids": [(6, 0, [main_company.id])],
+                "group_ids": [(6, 0, [group_user.id])],


Should be replaced by Command.set()

PieterPaulussen · 2025-10-28T22:47:52Z

test_queue_job/tests/test_json_field.py

+                "company_ids": [(6, 0, [main_company.id])],
+                "group_ids": [(6, 0, [group_user.id])],


Should be replaced by Command.set()

PieterPaulussen · 2025-10-28T22:48:09Z

test_queue_job/tests/test_job.py

+        User = cls.env["res.users"]
+        main_company = cls.env.ref("base.main_company")
+        group_user = cls.env.ref("base.group_user")
+        cls.demo_user = User.create(


Suggested change

User = cls.env["res.users"]

main_company = cls.env.ref("base.main_company")

group_user = cls.env.ref("base.group_user")

cls.demo_user = User.create(

main_company = cls.env.ref("base.main_company")

group_user = cls.env.ref("base.group_user")

cls.demo_user = cls.env["res.users"].create(

PieterPaulussen · 2025-10-28T22:48:33Z

test_queue_job/tests/test_json_field.py

+        User = cls.env["res.users"]
+        main_company = cls.env.ref("base.main_company")
+        group_user = cls.env.ref("base.group_user")
+        cls.demo_user = User.create(


Suggested change

User = cls.env["res.users"]

main_company = cls.env.ref("base.main_company")

group_user = cls.env.ref("base.group_user")

cls.demo_user = User.create(

main_company = cls.env.ref("base.main_company")

group_user = cls.env.ref("base.group_user")

cls.demo_user = cls.env["res.users"].create(

PieterPaulussen · 2025-10-28T23:01:53Z

@PieterPaulussen fyi, workers mode working fine here, is the runner starting properly on your end?

$ egrep "(runner|runner\.channels): .*(starting|initializing|.+runner ready|database connections ready|Configured channel)" odoo.log

@nilshamerlinck Curious, could you share your worker and channel configuration please? In my test, the jobs got enqueued, but were never actually processed.

Milan Topuzov added 11 commits October 1, 2025 18:01

[19.0] queue_job: migrate + tests

2a5ccb8

Scope: queue_job, test_queue_job only

[pre-commit] update excluded addons (queue_job/test_queue_job now ins…

ce67593

…tallable)

[pre-commit] apply hook updates + ruff fixes\n\n- Commit .pre-commit-…

b283cd8

…config.yaml excluded-addons update\n- Prettier reformat XML/JS/SCSS and pyproject changes\n- Fix ruff UP031 in controllers and job repr/exception

[lint] ruff fixes (E402, UP031, E501)

df50b83

[pre-commit] ruff-format applied

b7129d7

[pre-commit] ruff and format auto-fixes

a7d4364

[lint] tests: use odoo.tools.groupby instead of itertools.groupby

4da9fae

[pre-commit] reordered imports (ruff)

f494bcc

[lint] lazy translations + test groupby fix

3b733f1

[fix] channel: enforce root deletion guard in ondelete hook

ee67632

tishmen changed the title ~~[19.0] queue_job: migrate + tests~~ [19.0] [MIG] queue_job: migrate + tests Oct 1, 2025

OCA-git-bot added this to the 19.0 milestone Oct 1, 2025

OCA-git-bot mentioned this pull request Oct 1, 2025

Migration to version 19.0 #831

Open

8 tasks

hoangtrann suggested changes Oct 3, 2025

View reviewed changes

Milan Topuzov added 7 commits October 4, 2025 23:35

style(queue): convert safe string formatting to f-strings and extract…

d827d58

… error messages; keep logging/i18n/SQL intact

tests(doctest): reset optionflags to 0; remove no-op unlink override …

9aeebee

…(guard remains in ondelete)

style(queue): use PEP 604 unions in isinstance checks (Python 3.10+) …

9ac6b25

…where appropriate

style(queue): extract i18n raise messages into variables for consistency

99cc44f

autovacuum: restore original channel iteration form; keep linter sile…

211e467

…ncer (#no-search-all)

tests(common): restore search([]) for readability and silence linter …

620413a

…locally (#no-search-all)

chore(queue): remove unnecessary migration comments in security and c…

82d62a1

…hannel model

Milan Topuzov added 2 commits October 5, 2025 00:14

search: use dynamic datetime macros for date_created filters (now -1d…

81a1488

…/-7d/-30d) per core v19 behavior

security: set 'Job Queue' privilege sequence to 50 (under Settings › …

6d330f2

…Users)\n\n- Places the privilege below typical user/security items (e.g., OAuth providers at 30)\n- Functional change limited to security.xml data\n- pre-commit: all hooks pass locally

tishmen force-pushed the pr/queue_job_base branch from 1bb209c to 6d330f2 Compare October 4, 2025 23:14

pre-commit: all hooks pass locally

f685d12

tishmen requested a review from hoangtrann October 4, 2025 23:31

sbidoul reviewed Oct 5, 2025

View reviewed changes

queue_job/jobrunner/__init__.py Outdated Show resolved Hide resolved

sbidoul reviewed Oct 5, 2025

View reviewed changes

queue_job/tests/common.py Outdated Show resolved Hide resolved

sbidoul reviewed Oct 5, 2025

View reviewed changes

queue_job/models/queue_job.py Outdated Show resolved Hide resolved

hoangtrann reviewed Oct 6, 2025

View reviewed changes

Milan Topuzov added 2 commits October 11, 2025 15:06

chore(queue): remove Odoo 19 migration comments

d27f83d

Comment-only cleanup; no functional changes.

tests(common): improve _format_job_call readability by using intermed…

8dd4af0

…iate variables Address review nit: split complex f-strings into clearer parts; no functional change.

Milan Topuzov added 2 commits October 11, 2025 15:24

jobrunner: read [queue_job] from odoo.conf when server_environment mi…

231705d

…ssing Drop flat options merge; config-only change per review guidance.

models(queue_job): drop index_exists guards around create_index

9ea78c5

Align with review: create_index already checks existence; no functional change.

tishmen force-pushed the pr/queue_job_base branch from 6b95a96 to 038c334 Compare October 11, 2025 14:38

hoangtrann approved these changes Oct 12, 2025

View reviewed changes

amh-mw mentioned this pull request Oct 13, 2025

Update __manifest__.py #846

Closed

PieterPaulussen suggested changes Oct 28, 2025

View reviewed changes

		"company_ids": [(6, 0, [main_company.id])],
		"group_ids": [(6, 0, [group_user.id])],

	'["a", 1, {"_type": "odoo_recordset","model": "res.users", "ids": [1]}]'
	'["a", 1, {"_type": "odoo_recordset", "model": "res.users", "ids": [1]}]'

Uh oh!

[19.0] [MIG] queue_job: migrate + tests #840

Are you sure you want to change the base?

[19.0] [MIG] queue_job: migrate + tests #840

Uh oh!

Conversation

tishmen commented Oct 1, 2025

Uh oh!

sbidoul commented Oct 1, 2025

Uh oh!

sbidoul commented Oct 1, 2025

Uh oh!

hoangtrann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tishmen commented Oct 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hoangtrann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tishmen commented Oct 11, 2025

Uh oh!

hoangtrann left a comment

Choose a reason for hiding this comment

Uh oh!

richard-willdooit commented Oct 21, 2025

Uh oh!

PieterPaulussen commented Oct 27, 2025

Uh oh!

PieterPaulussen commented Oct 27, 2025

Uh oh!

nilshamerlinck commented Oct 28, 2025

Uh oh!

PieterPaulussen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PieterPaulussen commented Oct 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone