Skip to content

Conversation

@florentx
Copy link
Contributor

@florentx florentx commented Jun 2, 2025

Currently the check of Job state before manual action is loose:

  • for button: check happens when the Form view is loaded. Later when operator presses button, there's no guarantee that job is the same status. It could be processed in the meantime.
  • for mass-change using wizard, the check exists only on 1 wizard.

Here the check is made at the level of the action, and applies for both scenarios: button or wizard

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@florentx florentx marked this pull request as ready for review June 2, 2025 15:25
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement. But I'm uncomfortable with the __state_in method parameter and it seems there is a change in requeue related to WAIT_DEPENDENCIES?

@florentx florentx force-pushed the 18.0_button_checks branch from 5af9666 to 6008490 Compare June 3, 2025 08:41
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 12, 2025
@simahawk simahawk removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants