[18.0][MIG] purchase_order_product_recommendation_secondary_unit: Migration to version 18.0 #2888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to version 15.0 TT38334
Currently translated at 100.0% (5 of 5 strings) Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_order_product_recommendation_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_order_product_recommendation_secondary_unit/es/
…secondary unit and secondary quantity fields optional TT49686
carlos-lopez-tecnativa
suggested changes
Nov 13, 2025
purchase_order_product_recommendation_secondary_unit/wizards/purchase_order_recommendation.py
Outdated
Show resolved
Hide resolved
Comment on lines
+52
to
+84
| @api.onchange("secondary_uom_id", "secondary_uom_qty") | ||
| def _onchange_secondary_uom(self): | ||
| if not self.secondary_uom_id: | ||
| return | ||
| factor = self.secondary_uom_id.factor * self.product_id.uom_id.factor | ||
| qty = float_round( | ||
| self.secondary_uom_qty * factor, | ||
| precision_rounding=self.product_id.uom_id.rounding, | ||
| ) | ||
| if ( | ||
| float_compare( | ||
| self.units_included, | ||
| qty, | ||
| precision_rounding=self.product_id.uom_id.rounding, | ||
| ) | ||
| != 0 | ||
| ): | ||
| self.units_included = qty | ||
|
|
||
| @api.onchange("units_included") | ||
| def _onchange_units_included_purchase_order_secondary_unit(self): | ||
| if not self.secondary_uom_id: | ||
| return | ||
| factor = self.secondary_uom_id.factor * self.product_id.uom_id.factor | ||
| qty = float_round( | ||
| self.units_included / (factor or 1.0), | ||
| precision_rounding=self.secondary_uom_id.uom_id.rounding, | ||
| ) | ||
| if ( | ||
| float_compare( | ||
| self.secondary_uom_qty, | ||
| qty, | ||
| precision_rounding=self.secondary_uom_id.uom_id.rounding, | ||
| ) | ||
| != 0 | ||
| ): | ||
| self.secondary_uom_qty = qty |
Contributor
There was a problem hiding this comment.
The same comment from this other PR can be applied here: OCA/sale-workflow#4010 (comment)
… to version 18.0 TT54244
pilarvargas-tecnativa
force-pushed
the
18.0-mig-purchase_order_product_recommendation_secondary_unit
branch
from
962e4ab to
f0bf45e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa TT54244
@carlos-lopez-tecnativa @victoralmau please review