[17.0][MIG] purchase_analytic_global: Migration to 17.0 #2668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An analytic account field on the purchase order that applies the account on all the lines of the purchase order.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-14.0/purchase-workflow-14.0-purchase_analytic_global Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-14-0/purchase-workflow-14-0-purchase_analytic_global/
Currently translated at 100.0% (3 of 3 strings) Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_analytic_global Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_analytic_global/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_analytic_global Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_analytic_global/
Luca-Policastro
force-pushed
the
17.0-mig-purchase_analytic_global
branch
from
6988300 to
4d1247f
Compare
yankinmax
reviewed
May 14, 2025
Comment on lines
20
to
31
| def _compute_analytic_distribution(self): | ||
| """If all order line have same analytic distribution set analytic_distribution. | ||
| If no lines, respect value given by the user. | ||
| """ | ||
| for rec in self: | ||
| if rec.order_line: | ||
| al = rec.order_line[0].analytic_distribution or False | ||
| for ol in rec.order_line: | ||
| if ol.analytic_distribution != al: | ||
| al = False | ||
| break | ||
| rec.analytic_distribution = al |
There was a problem hiding this comment.
hello @Luca-Policastro
what do you think about such an approach from v18 solving the same issue:
https://github.com/OCA/purchase-workflow/blob/18.0/purchase_analytic_global/models/purchase_order.py
SilvioC2C
reviewed
May 15, 2025
Comment on lines
24
to
31
| for rec in self: | ||
| if rec.order_line: | ||
| al = rec.order_line[0].analytic_distribution or False | ||
| for ol in rec.order_line: | ||
| if ol.analytic_distribution != al: | ||
| al = False | ||
| break | ||
| rec.analytic_distribution = al |
There was a problem hiding this comment.
Suggested change
| for rec in self: | |
| if rec.order_line: | |
| al = rec.order_line[0].analytic_distribution or False | |
| for ol in rec.order_line: | |
| if ol.analytic_distribution != al: | |
| al = False | |
| break | |
| rec.analytic_distribution = al | |
| for po in self: | |
| if lines := po.order_line: | |
| distributions = set(ln.analytic_distribution for ln in lines) | |
| if len(distributions) == 1: | |
| po.analytic_distribution = tuple(distributions)[0] | |
| else: | |
| po.analytic_distribution = False |
Comment on lines
40
to
47
| @api.onchange("analytic_distribution") | ||
| def _onchange_analytic_distribution(self): | ||
| """When change analytic_distribution | ||
| set analytic distribution on all order lines""" | ||
| if self.analytic_distribution: | ||
| self.order_line.update( | ||
| {"analytic_distribution": self.analytic_distribution} | ||
| ) |
There was a problem hiding this comment.
Isn't this equivalent to the inverse method that's already in place?
Luca-Policastro
force-pushed
the
17.0-mig-purchase_analytic_global
branch
from
4d1247f to
0e35cca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration done from #2393