[MIG] purchase_order_archive: Migration to 16.0 #1993

CLaurelB · 2023-09-04T20:56:42Z

No description provided.

CLaurelB · 2023-09-04T21:01:37Z

@luisg123v @desdelinux could you review, please?

desdelinux

Functional Review is ok 👍

Could you review @HviorForgeFlow

desdelinux · 2023-09-12T21:10:38Z

Could you review @pedrobaeza @HviorForgeFlow @rafaelbn

HviorForgeFlow

Code review 👍
Thanks for adding tests, you should add yourself as a contributor :)
Why are you removing es.po translations?
@CLaurelB

CLaurelB · 2023-09-14T15:15:56Z

Code review 👍 Thanks for adding tests, you should add yourself as a contributor :) Why are you removing es.po translations? @CLaurelB

Thanks, I just added myself as a contributor.

About the es.po file, I removed it by mistake. It is now back in the last commit.

P.S. After updating the PR, I noticed that the pre-commit fails but the error is in the module purchase_request.

@HviorForgeFlow

HviorForgeFlow · 2023-09-14T15:18:57Z

@CLaurelB try rebasing with current 16.0 branch, I think it will fix this issue. Thanks for the fast response!

CLaurelB · 2023-09-14T15:32:46Z

@CLaurelB try rebasing with current 16.0 branch, I think it will fix this issue. Thanks for the fast response!

@HviorForgeFlow I just rebase my branch but It seems the issue is in the 16.0 branch.

https://github.com/OCA/purchase-workflow/actions/runs/6174540577/job/16759365412

HviorForgeFlow · 2023-09-14T15:48:27Z

Solving issue here: #2005

CLaurelB · 2023-09-14T16:44:20Z

Solving issue here: #2005

@HviorForgeFlow I rebase again and the issue is still there but only on the SHA-256 hash.

Currently translated at 100.0% (3 of 3 strings) Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_archive Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_archive/zh_CN/

CLaurelB · 2023-09-14T17:56:19Z

@HviorForgeFlow all checks have passed 👍

OCA-git-bot · 2023-09-14T18:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

HviorForgeFlow · 2023-09-15T05:50:03Z

/ocabot merge nobump

OCA-git-bot · 2023-09-15T05:50:13Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1993-by-HviorForgeFlow-bump-nobump, awaiting test results.

Signed-off-by HviorForgeFlow

OCA-git-bot · 2023-09-15T05:59:04Z

@HviorForgeFlow The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name purchase-workflow --branch 16.0 --addons-dir /tmp/tmpdcsfsgl_ --commit failed with output:

Traceback (most recent call last):
  File "/ocamt/lib/python3.8/site-packages/pypandoc/__init__.py", line 771, in ensure_pandoc_installed
    _ensure_pandoc_path()
  File "/ocamt/lib/python3.8/site-packages/pypandoc/__init__.py", line 750, in _ensure_pandoc_path
    raise OSError("No pandoc was found: either install pandoc and add it\n"
OSError: No pandoc was found: either install pandoc and add it
to your PATH or or call pypandoc.download_pandoc(...) or
install pypandoc wheels with included pandoc.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 11, in <module>
    load_entry_point('oca-maintainers-tools', 'console_scripts', 'oca-gen-addon-readme')()
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 526, in gen_addon_readme
    gen_one_addon_readme(
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 338, in gen_one_addon_readme
    fragment_filename = prepare_rst_fragment(addon_dir, fragment_name)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 266, in prepare_rst_fragment
    ensure_pandoc_installed()
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 124, in ensure_pandoc_installed
    pypandoc.ensure_pandoc_installed()
  File "/ocamt/lib/python3.8/site-packages/pypandoc/__init__.py", line 774, in ensure_pandoc_installed
    download_pandoc(url=url,
  File "/ocamt/lib/python3.8/site-packages/pypandoc/pandoc_download.py", line 267, in download_pandoc
    unpack(filename, targetfolder)
  File "/ocamt/lib/python3.8/site-packages/pypandoc/pandoc_download.py", line 95, in _handle_linux
    subprocess.check_call(cmd)
  File "/usr/lib/python3.8/subprocess.py", line 359, in check_call
    retcode = call(*popenargs, **kwargs)
  File "/usr/lib/python3.8/subprocess.py", line 340, in call
    with Popen(*popenargs, **kwargs) as p:
  File "/usr/lib/python3.8/subprocess.py", line 854, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.8/subprocess.py", line 1702, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'ar'

HviorForgeFlow · 2023-09-15T06:37:36Z

@sbidoul please take a look here: #1993 (comment)

HviorForgeFlow · 2023-09-15T16:34:50Z

/ocabot merge nobump

OCA-git-bot · 2023-09-15T16:34:59Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1993-by-HviorForgeFlow-bump-nobump, awaiting test results.

Signed-off-by HviorForgeFlow

OCA-git-bot · 2023-09-15T16:45:24Z

@HviorForgeFlow The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name purchase-workflow --branch 16.0 --addons-dir /tmp/tmpw9camg6d --commit failed with output:

Traceback (most recent call last):
  File "/ocamt/lib/python3.8/site-packages/pypandoc/__init__.py", line 771, in ensure_pandoc_installed
    _ensure_pandoc_path()
  File "/ocamt/lib/python3.8/site-packages/pypandoc/__init__.py", line 750, in _ensure_pandoc_path
    raise OSError("No pandoc was found: either install pandoc and add it\n"
OSError: No pandoc was found: either install pandoc and add it
to your PATH or or call pypandoc.download_pandoc(...) or
install pypandoc wheels with included pandoc.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 11, in <module>
    load_entry_point('oca-maintainers-tools', 'console_scripts', 'oca-gen-addon-readme')()
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 526, in gen_addon_readme
    gen_one_addon_readme(
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 338, in gen_one_addon_readme
    fragment_filename = prepare_rst_fragment(addon_dir, fragment_name)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 266, in prepare_rst_fragment
    ensure_pandoc_installed()
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 124, in ensure_pandoc_installed
    pypandoc.ensure_pandoc_installed()
  File "/ocamt/lib/python3.8/site-packages/pypandoc/__init__.py", line 774, in ensure_pandoc_installed
    download_pandoc(url=url,
  File "/ocamt/lib/python3.8/site-packages/pypandoc/pandoc_download.py", line 267, in download_pandoc
    unpack(filename, targetfolder)
  File "/ocamt/lib/python3.8/site-packages/pypandoc/pandoc_download.py", line 95, in _handle_linux
    subprocess.check_call(cmd)
  File "/usr/lib/python3.8/subprocess.py", line 359, in check_call
    retcode = call(*popenargs, **kwargs)
  File "/usr/lib/python3.8/subprocess.py", line 340, in call
    with Popen(*popenargs, **kwargs) as p:
  File "/usr/lib/python3.8/subprocess.py", line 854, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.8/subprocess.py", line 1702, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'ar'

sbidoul · 2023-09-16T08:51:51Z

I'm preparing a fix to the bot: OCA/oca-github-bot#259

sbidoul · 2023-09-16T13:23:19Z

Okay, bot updated. Let's see how it goes now.

/ocabot merge nobump

OCA-git-bot · 2023-09-16T13:23:29Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1993-by-sbidoul-bump-nobump, awaiting test results.

OCA-git-bot · 2023-09-16T13:31:57Z

Congratulations, your PR was merged at f78b8fd. Thanks a lot for contributing to OCA. ❤️

desdelinux approved these changes Sep 4, 2023

View reviewed changes

CLaurelB force-pushed the 16.0-mig-purchase_order_archive branch 3 times, most recently from 058df96 to 78e109c Compare September 4, 2023 22:06

HviorForgeFlow approved these changes Sep 14, 2023

View reviewed changes

OCA-git-bot added the approved label Sep 14, 2023

CLaurelB force-pushed the 16.0-mig-purchase_order_archive branch 3 times, most recently from 8f1b67e to 1dfbb78 Compare September 14, 2023 14:17

CLaurelB force-pushed the 16.0-mig-purchase_order_archive branch from 1dfbb78 to ef88d26 Compare September 14, 2023 15:23

CLaurelB force-pushed the 16.0-mig-purchase_order_archive branch from ef88d26 to 512dfdc Compare September 14, 2023 16:36

astirpe and others added 12 commits September 14, 2023 17:43

[11.0][ADD] purchase_order_archive

c2b4011

[UPD] README.rst

6b8203e

[UPD] Update purchase_order_archive.pot

9b10fa1

[12.0][MIG] purchase_order_archive

dcb1ab4

[UPD] README.rst

91180df

[UPD] Update purchase_order_archive.pot

8d77376

[UPD] README.rst

9ee138f

Added translation using Weblate (Chinese (Simplified))

ff0c414

[13.0][MIG] purchase_order_archive

28d61a4

[UPD] Update purchase_order_archive.pot

38b4dfe

[UPD] README.rst

d20bfe7

OCA-git-bot and others added 3 commits September 14, 2023 17:43

[UPD] README.rst

d2e7fc7

[IMP] purchase_order_archive: pre-commit stuff

ccaca31

[MIG] purchase_order_archive: Migration to 16.0

c65505a

CLaurelB force-pushed the 16.0-mig-purchase_order_archive branch from 512dfdc to c65505a Compare September 14, 2023 17:43

OCA-git-bot added the ready to merge label Sep 14, 2023

OCA-git-bot added the bot is merging ⏳ label Sep 15, 2023

OCA-git-bot added a commit that referenced this pull request Sep 15, 2023

Merge PR #1993 into 16.0

d4e1090

Signed-off-by HviorForgeFlow

OCA-git-bot removed the bot is merging ⏳ label Sep 15, 2023

kaynnan approved these changes Sep 15, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Sep 15, 2023

OCA-git-bot added a commit that referenced this pull request Sep 15, 2023

Merge PR #1993 into 16.0

588e1e4

Signed-off-by HviorForgeFlow

OCA-git-bot removed the bot is merging ⏳ label Sep 15, 2023

OCA-git-bot added the bot is merging ⏳ label Sep 16, 2023

OCA-git-bot merged commit f5570a7 into OCA:16.0 Sep 16, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 16, 2023

StefanRijnhart mentioned this pull request Dec 2, 2024

[16.0][MIG] purchase_order_archive #1914

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] purchase_order_archive: Migration to 16.0 #1993

[MIG] purchase_order_archive: Migration to 16.0 #1993

CLaurelB commented Sep 4, 2023

CLaurelB commented Sep 4, 2023

desdelinux left a comment

desdelinux commented Sep 12, 2023

HviorForgeFlow left a comment

CLaurelB commented Sep 14, 2023 •

edited

Loading

HviorForgeFlow commented Sep 14, 2023

CLaurelB commented Sep 14, 2023

HviorForgeFlow commented Sep 14, 2023

CLaurelB commented Sep 14, 2023 •

edited

Loading

CLaurelB commented Sep 14, 2023

OCA-git-bot commented Sep 14, 2023

HviorForgeFlow commented Sep 15, 2023

OCA-git-bot commented Sep 15, 2023

OCA-git-bot commented Sep 15, 2023

HviorForgeFlow commented Sep 15, 2023

HviorForgeFlow commented Sep 15, 2023

OCA-git-bot commented Sep 15, 2023

OCA-git-bot commented Sep 15, 2023

sbidoul commented Sep 16, 2023

sbidoul commented Sep 16, 2023

OCA-git-bot commented Sep 16, 2023

OCA-git-bot commented Sep 16, 2023

[MIG] purchase_order_archive: Migration to 16.0 #1993

[MIG] purchase_order_archive: Migration to 16.0 #1993

Conversation

CLaurelB commented Sep 4, 2023

CLaurelB commented Sep 4, 2023

desdelinux left a comment

Choose a reason for hiding this comment

desdelinux commented Sep 12, 2023

HviorForgeFlow left a comment

Choose a reason for hiding this comment

CLaurelB commented Sep 14, 2023 • edited Loading

HviorForgeFlow commented Sep 14, 2023

CLaurelB commented Sep 14, 2023

HviorForgeFlow commented Sep 14, 2023

CLaurelB commented Sep 14, 2023 • edited Loading

CLaurelB commented Sep 14, 2023

OCA-git-bot commented Sep 14, 2023

HviorForgeFlow commented Sep 15, 2023

OCA-git-bot commented Sep 15, 2023

OCA-git-bot commented Sep 15, 2023

HviorForgeFlow commented Sep 15, 2023

HviorForgeFlow commented Sep 15, 2023

OCA-git-bot commented Sep 15, 2023

OCA-git-bot commented Sep 15, 2023

sbidoul commented Sep 16, 2023

sbidoul commented Sep 16, 2023

OCA-git-bot commented Sep 16, 2023

OCA-git-bot commented Sep 16, 2023

CLaurelB commented Sep 14, 2023 •

edited

Loading

CLaurelB commented Sep 14, 2023 •

edited

Loading