[MIG] purchase_package_qty: Migration to 18.0

Author: phucph

purchase_package_qty/__manifest__.py

@@ -25,23 +25,22 @@
 
 {
     "name": "Purchase - Package Quantity",
-    "version": "12.0.1.0.0",
+    "version": "18.0.1.0.0",
     "category": "Purchase",
-    "author": "GRAP, Druidoo",
+    "author": "GRAP, Druidoo, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/purchase-workflow",
     "license": "AGPL-3",
     "depends": [
         "account",
         "product",
-        "purchase_discount",
+        "purchase_stock",
     ],
     "data": [
         "views/product_supplierinfo_view.xml",
         "views/purchase_order_view.xml",
         "views/stock_picking_view.xml",
         "views/account_invoice_view.xml",
         "views/report_stockinventory.xml",
-        "views/stock_inventory_view.xml",
         "views/report_invoice.xml",
         "data/function.xml",
     ],

purchase_package_qty/models/__init__.py

@@ -31,5 +31,4 @@
 from . import stock_move
 from . import account_invoice
 from . import account_invoice_line
-from . import stock_inventory
 from . import stock_move_line

purchase_package_qty/models/account_invoice.py

@@ -27,11 +27,11 @@
 
 
 class AccountInvoice(models.Model):
-    _inherit = "account.invoice"
+    _inherit = "account.move"
 
-    @api.onchange("purchase_id")
-    def purchase_order_change(self):
-        res = super().purchase_order_change()
+    @api.onchange("purchase_vendor_bill_id", "purchase_id")
+    def _onchange_purchase_auto_complete(self):
+        res = super()._onchange_purchase_auto_complete()
         for line in self.invoice_line_ids:
             if line.quantity == 0:
                 self.invoice_line_ids -= line
@@ -42,30 +42,3 @@ def purchase_order_change(self):
                     line.package_qty and line.quantity / line.package_qty or 0
                 )
         return res
-
-    @api.multi
-    def get_taxes_values(self):
-        tax_grouped = {}
-        round_curr = self.currency_id.round
-        for line in self.invoice_line_ids:
-            if not line.account_id:
-                continue
-            price_unit = line.price_unit * (1 - (line.discount or 0.0) / 100.0)
-            if line.price_policy == "package":
-                quantity = line.product_qty_package
-            else:
-                quantity = line.quantity
-            taxes = line.invoice_line_tax_ids.compute_all(
-                price_unit, self.currency_id, quantity, line.product_id, self.partner_id
-            )["taxes"]
-            for tax in taxes:
-                val = self._prepare_tax_line_vals(line, tax)
-                key = self.env["account.tax"].browse(tax["id"]).get_grouping_key(val)
-
-                if key not in tax_grouped:
-                    tax_grouped[key] = val
-                    tax_grouped[key]["base"] = round_curr(val["base"])
-                else:
-                    tax_grouped[key]["amount"] += val["amount"]
-                    tax_grouped[key]["base"] += round_curr(val["base"])
-        return tax_grouped

purchase_package_qty/models/account_invoice_line.py

@@ -27,17 +27,14 @@
 
 
 class AccountInvoiceLine(models.Model):
-    _inherit = "account.invoice.line"
+    _inherit = "account.move.line"
 
-    package_qty = fields.Float(
-        "Package Qty", help="""The quantity of products in the supplier package."""
-    )
+    package_qty = fields.Float(help="The quantity of products in the supplier package.")
     product_qty_package = fields.Float(
-        "Number of packages", help="""The number of packages you'll buy."""
+        "Number of packages", help="The number of packages you'll buy."
     )
     price_policy = fields.Selection(
         [("uom", "per UOM"), ("package", "per Package")],
-        "Price Policy",
         default="uom",
         required=True,
     )
@@ -56,28 +53,10 @@ def onchange_product_qty_package(self):
     def onchange_package_qty(self):
         self.quantity = self.package_qty * self.product_qty_package
 
-    # pylint: disable=W8104
-    @api.one
-    @api.depends(
-        "price_unit",
-        "discount",
-        "invoice_line_tax_ids",
-        "quantity",
-        "product_id",
-        "invoice_id.partner_id",
-        "invoice_id.currency_id",
-        "invoice_id.company_id",
-        "invoice_id.date_invoice",
-        "invoice_id.date",
-        "product_qty_package",
-        "price_policy",
-    )
-    def _compute_price(self):
-        if self.price_policy == "package":
-            origin_quantiy = self.quantity
-            self.quantity = self.product_qty_package
-            res = super()._compute_price()
-            self.quantity = origin_quantiy
-            return res
-        else:
-            return super()._compute_price()
+    @api.depends("display_type", "price_policy")
+    def _compute_quantity(self):
+        res = super()._compute_quantity()
+        for line in self:
+            if line.price_policy == "package":
+                line.quantity = line.product_qty_package
+        return res

purchase_package_qty/models/product_supplierinfo.py

@@ -23,39 +23,35 @@
 #
 ##############################################################################
 
-from odoo import _, api, fields, models
-
-from odoo.addons import decimal_precision as dp
+from odoo import api, fields, models
+from odoo.exceptions import ValidationError
 
 
 class ProductSupplierinfo(models.Model):
     _inherit = "product.supplierinfo"
 
     # Columns section
     package_qty = fields.Float(
-        "Package Qty",
-        digits=dp.get_precision("Product UoM"),
+        digits="Product UoM",
         help="""The quantity of products in the supplier package."""
         """ You will always have to buy a multiple of this quantity.""",
         default=1,
     )
     indicative_package = fields.Boolean(
-        "Indicative Package",
         help="""If checked, the system will not force you to purchase"""
         """ a strict multiple of package quantity""",
         default=False,
     )
     price_policy = fields.Selection(
         [("uom", "per UOM"), ("package", "per Package")],
-        "Price Policy",
         default="uom",
         required=True,
     )
     base_price = fields.Float(
         "Price",
         required=False,
         default=0.00,
-        digits=dp.get_precision("Product Price"),
+        digits="Product Price",
         help="The price to purchase a product",
     )
     price = fields.Float(
@@ -67,7 +63,6 @@ class ProductSupplierinfo(models.Model):
     )
 
     @api.depends("base_price", "price_policy", "package_qty")
-    @api.multi
     def _compute_price(self):
         for psi in self:
             if psi.price_policy == "package":
@@ -77,32 +72,31 @@ def _compute_price(self):
             else:
                 psi.price = psi.base_price
 
-    @api.model
-    def create(self, vals):
-        if not vals.get("base_price", False):
-            if vals.get("price", False):
-                vals["base_price"] = vals["price"]
-                del vals["price"]
-            else:
-                vals["base_price"] = 0
-        res = super().create(vals)
+    @api.model_create_multi
+    def create(self, vals_list):
+        for vals in vals_list:
+            if not vals.get("base_price"):
+                if vals.get("price"):
+                    vals["base_price"] = vals["price"]
+                    del vals["price"]
+                else:
+                    vals["base_price"] = 0
+        res = super().create(vals_list)
         return res
 
-    @api.multi
     def write(self, vals):
-        if not vals.get("base_price", False):
-            if vals.get("price", False):
+        if not vals.get("base_price"):
+            if vals.get("price"):
                 vals["base_price"] = vals["price"]
                 del vals["price"]
         return super().write(vals)
 
     # Constraints section
-    @api.multi
     @api.constrains("package_qty")
     def _check_package_qty(self):
         for psi in self:
             if psi.package_qty == 0:
-                raise ValueError(_("The package quantity cannot be 0."))
+                raise ValidationError(self.env._("The package quantity cannot be 0."))
 
     # Init section
     @api.model

purchase_package_qty/models/product_template.py

@@ -29,16 +29,15 @@
 class ProductTemplate(models.Model):
     _inherit = "product.template"
 
-    @api.depends(
-        "seller_ids",
-    )
-    @api.multi
-    def _compute_default_seller_id(self):
-        for pt in self:
-            pt.default_seller_id = pt.seller_ids and pt.seller_ids[0] or False
-
     default_seller_id = fields.Many2one(
-        string="Default Seller",
         comodel_name="product.supplierinfo",
         compute="_compute_default_seller_id",
     )
+
+    @api.depends("seller_ids")
+    def _compute_default_seller_id(self):
+        for pt in self:
+            default_seller_id = False
+            if pt.seller_ids:
+                default_seller_id = pt.seller_ids[0]
+            pt.default_seller_id = default_seller_id

purchase_package_qty/models/purchase_order.py

@@ -23,13 +23,12 @@
 #
 ##############################################################################
 
-from odoo import api, models
+from odoo import models
 
 
 class PurchaseOrder(models.Model):
     _inherit = "purchase.order"
 
-    @api.multi
     def _add_supplier_to_product(self):
         # we have to override this method to modify the vals
         # Do not add a contact as a supplier
@@ -40,7 +39,7 @@ def _add_supplier_to_product(self):
         )
         for line in self.order_line:
             if (
-                partner not in line.product_id.seller_ids.mapped("name")
+                partner not in line.product_id.seller_ids.mapped("partner_id")
                 and len(line.product_id.seller_ids) <= 10
             ):
                 supplierinfo = line._get_supplierinfovals(partner)
@@ -52,7 +51,6 @@ def _add_supplier_to_product(self):
                 except Exception:  # If no Write access rights -> just ignore
                     break
 
-    @api.multi
     def action_view_picking(self):
         res = super().action_view_picking()
         res["context"].update({"readonly_by_pass": True})