[IMP] purchase_package_qty: pre-commit auto fixes

Author: phucph

purchase_package_qty/__manifest__.py

@@ -24,25 +24,25 @@
 ##############################################################################
 
 {
-    'name': 'Purchase - Package Quantity',
-    'version': '12.0.1.0.0',
-    'category': 'Purchase',
-    'author': 'GRAP, Druidoo',
-    'website': 'https://cooplalouve.fr',
-    'license': 'AGPL-3',
-    'depends': [
-        'account',
-        'product',
-        'purchase_discount',
+    "name": "Purchase - Package Quantity",
+    "version": "12.0.1.0.0",
+    "category": "Purchase",
+    "author": "GRAP, Druidoo",
+    "website": "https://github.com/OCA/purchase-workflow",
+    "license": "AGPL-3",
+    "depends": [
+        "account",
+        "product",
+        "purchase_discount",
     ],
-    'data': [
-        'views/product_supplierinfo_view.xml',
-        'views/purchase_order_view.xml',
-        'views/stock_picking_view.xml',
-        'views/account_invoice_view.xml',
-        'views/report_stockinventory.xml',
-        'views/stock_inventory_view.xml',
-        'views/report_invoice.xml',
-        'data/function.xml',
+    "data": [
+        "views/product_supplierinfo_view.xml",
+        "views/purchase_order_view.xml",
+        "views/stock_picking_view.xml",
+        "views/account_invoice_view.xml",
+        "views/report_stockinventory.xml",
+        "views/stock_inventory_view.xml",
+        "views/report_invoice.xml",
+        "data/function.xml",
     ],
 }

purchase_package_qty/data/function.xml

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="UTF-8"?>
+<?xml version="1.0" encoding="UTF-8" ?>
 <!-- ********************************************************************** -->
 <!--Purchase - Package Quantity Module for Odoo                             -->
 <!--Copyright (C) 2019-Today: La Louve (<https://cooplalouve.fr>)           -->
@@ -7,20 +7,17 @@
 <!--License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).      -->
 <!--@author Julien Weste                                                    -->
 <!--@author Sylvain LE GAL (https://twitter.com/legalsylvain)               -->
-
 <!--This program is free software: you can redistribute it and/or modify    -->
 <!--it under the terms of the GNU Affero General Public License as          -->
 <!--published by the Free Software Foundation, either version 3 of the      -->
 <!--License, or (at your option) any later version.                         -->
-
 <!--This program is distributed in the hope that it will be useful,         -->
 <!--but WITHOUT ANY WARRANTY; without even the implied warranty of          -->
 <!--MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the           -->
 <!--GNU Affero General Public License for more details.                     -->
-
 <!--You should have received a copy of the GNU Affero General Public License-->
 <!--along with this program.  If not, see <http://www.gnu.org/licenses/>.   -->
 <!-- ********************************************************************** -->
 <odoo>
-    <function model="product.supplierinfo" name="_init_package_qty"/>
+    <function model="product.supplierinfo" name="_init_package_qty" />
 </odoo>

purchase_package_qty/models/account_invoice.py

@@ -27,19 +27,20 @@
 
 
 class AccountInvoice(models.Model):
-    _inherit = 'account.invoice'
+    _inherit = "account.invoice"
 
-    @api.onchange('purchase_id')
+    @api.onchange("purchase_id")
     def purchase_order_change(self):
-        res = super(AccountInvoice, self).purchase_order_change()
+        res = super().purchase_order_change()
         for line in self.invoice_line_ids:
             if line.quantity == 0:
                 self.invoice_line_ids -= line
             else:
                 line.price_policy = line.purchase_line_id.price_policy
                 line.package_qty = line.purchase_line_id.package_qty
-                line.product_qty_package = line.package_qty and\
-                    line.quantity / line.package_qty or 0
+                line.product_qty_package = (
+                    line.package_qty and line.quantity / line.package_qty or 0
+                )
         return res
 
     @api.multi
@@ -50,22 +51,21 @@ def get_taxes_values(self):
             if not line.account_id:
                 continue
             price_unit = line.price_unit * (1 - (line.discount or 0.0) / 100.0)
-            if line.price_policy == 'package':
+            if line.price_policy == "package":
                 quantity = line.product_qty_package
             else:
                 quantity = line.quantity
             taxes = line.invoice_line_tax_ids.compute_all(
-                price_unit, self.currency_id, quantity, line.product_id,
-                self.partner_id)['taxes']
+                price_unit, self.currency_id, quantity, line.product_id, self.partner_id
+            )["taxes"]
             for tax in taxes:
                 val = self._prepare_tax_line_vals(line, tax)
-                key = self.env['account.tax'].browse(
-                    tax['id']).get_grouping_key(val)
+                key = self.env["account.tax"].browse(tax["id"]).get_grouping_key(val)
 
                 if key not in tax_grouped:
                     tax_grouped[key] = val
-                    tax_grouped[key]['base'] = round_curr(val['base'])
+                    tax_grouped[key]["base"] = round_curr(val["base"])
                 else:
-                    tax_grouped[key]['amount'] += val['amount']
-                    tax_grouped[key]['base'] += round_curr(val['base'])
+                    tax_grouped[key]["amount"] += val["amount"]
+                    tax_grouped[key]["base"] += round_curr(val["base"])
         return tax_grouped

purchase_package_qty/models/account_invoice_line.py

@@ -27,44 +27,57 @@
 
 
 class AccountInvoiceLine(models.Model):
-    _inherit = 'account.invoice.line'
+    _inherit = "account.invoice.line"
 
     package_qty = fields.Float(
-        'Package Qty',
-        help="""The quantity of products in the supplier package.""")
+        "Package Qty", help="""The quantity of products in the supplier package."""
+    )
     product_qty_package = fields.Float(
-        'Number of packages', help="""The number of packages you'll buy.""")
+        "Number of packages", help="""The number of packages you'll buy."""
+    )
     price_policy = fields.Selection(
-        [('uom', 'per UOM'), ('package', 'per Package')], "Price Policy",
-        default='uom', required=True)
+        [("uom", "per UOM"), ("package", "per Package")],
+        "Price Policy",
+        default="uom",
+        required=True,
+    )
 
-    @api.onchange('quantity')
+    @api.onchange("quantity")
     def onchange_product_qty(self):
         if self.package_qty:
             self.product_qty_package = self.quantity / self.package_qty
 
-    @api.onchange('product_qty_package')
+    @api.onchange("product_qty_package")
     def onchange_product_qty_package(self):
         if self.product_qty_package == int(self.product_qty_package):
             self.quantity = self.package_qty * self.product_qty_package
 
-    @api.onchange('package_qty')
+    @api.onchange("package_qty")
     def onchange_package_qty(self):
         self.quantity = self.package_qty * self.product_qty_package
 
     # pylint: disable=W8104
     @api.one
     @api.depends(
-        'price_unit', 'discount', 'invoice_line_tax_ids', 'quantity',
-        'product_id', 'invoice_id.partner_id', 'invoice_id.currency_id',
-        'invoice_id.company_id', 'invoice_id.date_invoice', 'invoice_id.date',
-        'product_qty_package', 'price_policy')
+        "price_unit",
+        "discount",
+        "invoice_line_tax_ids",
+        "quantity",
+        "product_id",
+        "invoice_id.partner_id",
+        "invoice_id.currency_id",
+        "invoice_id.company_id",
+        "invoice_id.date_invoice",
+        "invoice_id.date",
+        "product_qty_package",
+        "price_policy",
+    )
     def _compute_price(self):
-        if self.price_policy == 'package':
+        if self.price_policy == "package":
             origin_quantiy = self.quantity
             self.quantity = self.product_qty_package
-            res = super(AccountInvoiceLine, self)._compute_price()
+            res = super()._compute_price()
             self.quantity = origin_quantiy
             return res
         else:
-            return super(AccountInvoiceLine, self)._compute_price()
+            return super()._compute_price()

purchase_package_qty/models/product_supplierinfo.py

@@ -23,40 +23,54 @@
 #
 ##############################################################################
 
-from odoo import models, fields, api, _
+from odoo import _, api, fields, models
+
 from odoo.addons import decimal_precision as dp
 
 
 class ProductSupplierinfo(models.Model):
-    _inherit = 'product.supplierinfo'
+    _inherit = "product.supplierinfo"
 
     # Columns section
     package_qty = fields.Float(
-        'Package Qty', digits=dp.get_precision('Product UoM'),
+        "Package Qty",
+        digits=dp.get_precision("Product UoM"),
         help="""The quantity of products in the supplier package."""
         """ You will always have to buy a multiple of this quantity.""",
-        default=1)
+        default=1,
+    )
     indicative_package = fields.Boolean(
-        'Indicative Package',
+        "Indicative Package",
         help="""If checked, the system will not force you to purchase"""
         """ a strict multiple of package quantity""",
-        default=False)
+        default=False,
+    )
     price_policy = fields.Selection(
-        [('uom', 'per UOM'), ('package', 'per Package')], "Price Policy",
-        default='uom', required=True)
+        [("uom", "per UOM"), ("package", "per Package")],
+        "Price Policy",
+        default="uom",
+        required=True,
+    )
     base_price = fields.Float(
-        'Price', required=False, default=0.00,
-        digits=dp.get_precision('Product Price'),
-        help="The price to purchase a product")
+        "Price",
+        required=False,
+        default=0.00,
+        digits=dp.get_precision("Product Price"),
+        help="The price to purchase a product",
+    )
     price = fields.Float(
-        "Price per Unit", compute='_compute_price',
-        required=False, store=True, readonly=True)
+        "Price per Unit",
+        compute="_compute_price",
+        required=False,
+        store=True,
+        readonly=True,
+    )
 
-    @api.depends('base_price', 'price_policy', 'package_qty')
+    @api.depends("base_price", "price_policy", "package_qty")
     @api.multi
     def _compute_price(self):
         for psi in self:
-            if psi.price_policy == 'package':
+            if psi.price_policy == "package":
                 if psi.package_qty == 0:
                     psi.package_qty = 1
                 psi.price = psi.base_price / psi.package_qty
@@ -65,30 +79,30 @@ def _compute_price(self):
 
     @api.model
     def create(self, vals):
-        if not vals.get('base_price', False):
-            if vals.get('price', False):
-                vals['base_price'] = vals['price']
-                del vals['price']
+        if not vals.get("base_price", False):
+            if vals.get("price", False):
+                vals["base_price"] = vals["price"]
+                del vals["price"]
             else:
-                vals['base_price'] = 0
-        res = super(ProductSupplierinfo, self).create(vals)
+                vals["base_price"] = 0
+        res = super().create(vals)
         return res
 
     @api.multi
     def write(self, vals):
-        if not vals.get('base_price', False):
-            if vals.get('price', False):
-                vals['base_price'] = vals['price']
-                del vals['price']
-        return super(ProductSupplierinfo, self).write(vals)
+        if not vals.get("base_price", False):
+            if vals.get("price", False):
+                vals["base_price"] = vals["price"]
+                del vals["price"]
+        return super().write(vals)
 
     # Constraints section
     @api.multi
-    @api.constrains('package_qty')
+    @api.constrains("package_qty")
     def _check_package_qty(self):
         for psi in self:
             if psi.package_qty == 0:
-                raise ValueError(_('The package quantity cannot be 0.'))
+                raise ValueError(_("The package quantity cannot be 0."))
 
     # Init section
     @api.model
@@ -97,9 +111,9 @@ def _init_package_qty(self):
         for psi in psi_ids:
             vals = {}
             if not psi.package_qty:
-                vals['package_qty'] = max(psi.min_qty, 1)
+                vals["package_qty"] = max(psi.min_qty, 1)
             if not psi.base_price:
-                vals['base_price'] = psi.price
+                vals["base_price"] = psi.price
             if vals:
                 psi.write(vals)
         return psi_ids.ids

purchase_package_qty/models/product_template.py

@@ -27,15 +27,18 @@
 
 
 class ProductTemplate(models.Model):
-    _inherit = 'product.template'
+    _inherit = "product.template"
 
-    @api.depends('seller_ids',)
+    @api.depends(
+        "seller_ids",
+    )
     @api.multi
     def _compute_default_seller_id(self):
         for pt in self:
             pt.default_seller_id = pt.seller_ids and pt.seller_ids[0] or False
 
     default_seller_id = fields.Many2one(
-        string='Default Seller',
-        comodel_name='product.supplierinfo',
-        compute='_compute_default_seller_id',)
+        string="Default Seller",
+        comodel_name="product.supplierinfo",
+        compute="_compute_default_seller_id",
+    )

purchase_package_qty/models/purchase_order.py

@@ -27,20 +27,25 @@
 
 
 class PurchaseOrder(models.Model):
-    _inherit = 'purchase.order'
+    _inherit = "purchase.order"
 
     @api.multi
     def _add_supplier_to_product(self):
         # we have to override this method to modify the vals
         # Do not add a contact as a supplier
-        partner = self.partner_id if not self.partner_id.parent_id\
+        partner = (
+            self.partner_id
+            if not self.partner_id.parent_id
             else self.partner_id.parent_id
+        )
         for line in self.order_line:
-            if partner not in line.product_id.seller_ids.mapped('name') and\
-                    len(line.product_id.seller_ids) <= 10:
+            if (
+                partner not in line.product_id.seller_ids.mapped("name")
+                and len(line.product_id.seller_ids) <= 10
+            ):
                 supplierinfo = line._get_supplierinfovals(partner)
                 vals = {
-                    'seller_ids': [(0, 0, supplierinfo)],
+                    "seller_ids": [(0, 0, supplierinfo)],
                 }
                 try:
                     line.product_id.write(vals)
@@ -49,8 +54,6 @@ def _add_supplier_to_product(self):
 
     @api.multi
     def action_view_picking(self):
-        res = super(PurchaseOrder, self).action_view_picking()
-        res['context'].update({
-            'readonly_by_pass': True
-        })
+        res = super().action_view_picking()
+        res["context"].update({"readonly_by_pass": True})
         return res