-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0] [MIG] project_key: Migration to 18.0 #1386
base: 18.0
Are you sure you want to change the base?
Conversation
Currently translated at 100.0% (12 of 12 strings) Translation: project-14.0/project-14.0-project_key Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_key/es_AR/
Currently translated at 83.3% (10 of 12 strings) Translation: project-14.0/project-14.0-project_key Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_key/it/
a project, must be linked to the project company to avoid security issues.
[email protected]: Update with 'model_create_multi' decorator to allow several records to be taken at once [email protected]: Fix _rec_names_search on project by including 'name'. Fix task creation.
Currently translated at 100.0% (8 of 8 strings) Translation: project-16.0/project-16.0-project_key Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_key/fr/
e23f91d
to
68c3589
Compare
If not much changes, can you do the pr to 17.0? |
</field> | ||
</field> | ||
</record> | ||
<record id="view_task_tree2_extend_with_key" model="ir.ui.view"> | ||
<field name="name">project.task.tree</field> | ||
<record id="view_task_list2_extend_with_key" model="ir.ui.view"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, I'm not sure the external id should be changed unless Odoo does the same thing.
68c3589
to
88765e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
project_key/tests/test_task.py
Outdated
@@ -19,7 +19,7 @@ def test_02_compute_task_url(self): | |||
|
|||
def test_03_create_task_project_in_context(self): | |||
self.Task.with_context( | |||
active_model="project.project", active_id=self.project_1.id | |||
active_model="project.project", id=self.project_1.id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard-coded model name instead of active_model.
model="project.project", id=self.project_1.id
88765e3
to
8b5e4df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, can you check the PR for 17.0? That way, we kill two birds with one stone.
Migration from 16.0 to 18.0
Issue: #1347