-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] crm_tag_multi_company #767
[16.0][MIG] crm_tag_multi_company #767
Conversation
@MarinaAForgeFlow could you squash Migration 16.0 commits? also it would be nice to put in the description of the PR that you are also adding a couple of new modules :) |
1dc34c9
to
ed5c1a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code review / no test.
thanks for porting this module !
<field name="arch" type="xml"> | ||
<field name="name" position="after"> | ||
<field name="company_id" groups="base.group_multi_company" /> | ||
<field name="company_id" invisible="1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this second line mandatory ?
it is not explained in the odoo documentation.
https://www.odoo.com/documentation/18.0/fr/developer/howtos/company.html#views
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood it was needed after reading this point on the migration notes for v16.0 (https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0):
On the same mood, you should check if the fields protected by a group interact in some way with business logic or UI. For example, a field being part of a domain of another field, or being used in copy/defaults. An special case is the field company_id, which is always used internally for domains on many2one fields referencing multi-company aware records. On these cases, you have to add the same field twice, one with the group, and another invisible without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot !
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at ac41464. Thanks a lot for contributing to OCA. ❤️ |
Supersedes PR #659
[ADD] crm_tag_multi_company_sale: glue module
[ADD] crm_tag_multi_company_event_crm: glue module