Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] crm_tag_multi_company #767

Merged
merged 8 commits into from
Feb 20, 2025

Conversation

MarinaAForgeFlow
Copy link
Contributor

@MarinaAForgeFlow MarinaAForgeFlow commented Feb 4, 2025

Supersedes PR #659

[ADD] crm_tag_multi_company_sale: glue module
[ADD] crm_tag_multi_company_event_crm: glue module

@JordiMForgeFlow
Copy link
Contributor

@MarinaAForgeFlow could you squash Migration 16.0 commits? also it would be nice to put in the description of the PR that you are also adding a couple of new modules :)

@MarinaAForgeFlow MarinaAForgeFlow force-pushed the 16.0-mig-crm_tag_multi_company branch from 1dc34c9 to ed5c1a1 Compare February 4, 2025 09:37
@MarinaAForgeFlow MarinaAForgeFlow changed the title [16.0][MIG] crm_tag_multi_company: [16.0][MIG] crm_tag_multi_company Feb 4, 2025
Copy link

@AlexPForgeFlow AlexPForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review!

@legalsylvain legalsylvain added this to the 16.0 milestone Feb 11, 2025
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review / no test.

thanks for porting this module !

<field name="arch" type="xml">
<field name="name" position="after">
<field name="company_id" groups="base.group_multi_company" />
<field name="company_id" invisible="1" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this second line mandatory ?
it is not explained in the odoo documentation.

https://www.odoo.com/documentation/18.0/fr/developer/howtos/company.html#views

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understood it was needed after reading this point on the migration notes for v16.0 (https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0):

On the same mood, you should check if the fields protected by a group interact in some way with business logic or UI. For example, a field being part of a domain of another field, or being used in copy/defaults. An special case is the field company_id, which is always used internally for domains on many2one fields referencing multi-company aware records. On these cases, you have to add the same field twice, one with the group, and another invisible without it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot !

@legalsylvain
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-767-by-legalsylvain-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ac41464. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit f4ec1a4 into OCA:16.0 Feb 20, 2025
5 of 7 checks passed
@MiquelRForgeFlow MiquelRForgeFlow deleted the 16.0-mig-crm_tag_multi_company branch February 20, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants