[16.0][FIX] partner_multi_company: remove unnecessary rule rewrite hooks #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `base_multi_company` supports `('company_id', 'in', some_ids + [False])` domains since OCA#760, it's time to remove the (un)install hooks that changed those rules.
The fix is important when migrating a database from previous versions where these hooks didn't exist. In those cases, users wouldn't be able to browse some partners, getting a weird `AccessError`.
FWIW, [upstream rules changed for performance][2], so the uninstall hook had to be changed nevertheless.
[2]: odoo/odoo@a04df5c#diff-1f2cafa0e26df218210181c72e599c279fd093c4215d1dc1da5ef8875195e6c2L23-R23
@moduon MT-8863
yajo
force-pushed
the
16.0-partner_multi_company-remove_hooks
branch
from
82e3cfa to
b51967d
Compare
pedrobaeza
changed the title
pedrobaeza
approved these changes
Feb 12, 2025
EmilioPascual
approved these changes
Feb 13, 2025
|
This PR has the |
|
This seems ready to merge @pedrobaeza |
|
/ocabot merge major |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 64527ea. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
base_multi_companysupports('company_id', 'in', some_ids + [False])domains since #760, it's time to remove the (un)install hooks that changed those rules.The fix is important when migrating a database from previous versions where these hooks didn't exist. In those cases, users wouldn't be able to browse some partners, getting a weird
AccessError.FWIW, upstream rules changed for performance, so the uninstall hook had to be changed nevertheless.
Draft until:
in Falsesearch operators #760Instructions for functional tests: This refactor is internal and should not be noticed functionally. The module
partner_multi_companyshould work just as always. If so, then this is good.@moduon MT-8863