Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] partner_category_multi_company #758

Merged
merged 8 commits into from
Feb 24, 2025
Merged

[16.0][MIG] partner_category_multi_company #758

merged 8 commits into from
Feb 24, 2025

Conversation

JordiMForgeFlow
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow commented Jan 27, 2025 •
edited
Loading

  • Migration of res_partner_category_multi_company
  • Rename res_partner_category_multi_company to partner_category_multi_company to make it shorter and aligned with the majority of partner related modules.
  • [ADD] partner_category_multi_company_account: glue module
  • [ADD] partner_category_multi_company_analytic: glue module

@JordiMForgeFlow JordiMForgeFlow changed the title 16.0 mig res partner categorymulti_company [16.0][MIG] res_partner_category_multi_company Jan 27, 2025
@JordiMForgeFlow JordiMForgeFlow force-pushed the 16.0-mig-res_partner_category_multi_company branch from 967a4d6 to 40223e1 Compare January 27, 2025 14:10
@MarinaAForgeFlow MarinaAForgeFlow force-pushed the 16.0-mig-res_partner_category_multi_company branch 2 times, most recently from 8513575 to 9713af7 Compare January 29, 2025 11:07
@legalsylvain legalsylvain added this to the 16.0 milestone Feb 11, 2025
@JordiMForgeFlow JordiMForgeFlow changed the title [16.0][MIG] res_partner_category_multi_company [16.0][MIG] partner_category_multi_company Feb 24, 2025
AaronHForgeFlow
AaronHForgeFlow approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Feb 24, 2025
Merged
@pedrobaeza
Copy link
Member

pedrobaeza commented Feb 24, 2025 •
edited
Loading

You have to rename the whole commit history using these commands:

git filter-branch --tree-filter 'if [ -d res_partner_category_multi_company ]; then mv res_partner_category_multi_company partner_category_multi_company; fi' HEAD
git rebase origin/16.0

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@JordiMForgeFlow JordiMForgeFlow force-pushed the 16.0-mig-res_partner_category_multi_company branch from 9713af7 to 7189261 Compare February 24, 2025 12:16
@JordiMForgeFlow JordiMForgeFlow force-pushed the 16.0-mig-res_partner_category_multi_company branch from 7189261 to 4a20376 Compare February 24, 2025 12:20
@JordiMForgeFlow
Copy link
Contributor Author

@pedrobaeza done :)

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-758-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 24, 2025
@OCA-git-bot
Merge PR #758 into 16.0
0cf2de8 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-758-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1dfdbbb. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 877a9bd into OCA:16.0 Feb 24, 2025
7 checks passed
@MiquelRForgeFlow MiquelRForgeFlow deleted the 16.0-mig-res_partner_category_multi_company branch February 24, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
10 participants
@JordiMForgeFlow @pedrobaeza @OCA-git-bot @AaronHForgeFlow @MiquelRForgeFlow @legalsylvain @sbejaoui @badbole @pedrocs-exo @MarinaAForgeFlow