Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] res_company_search_view: Migration to 18.0 #751

Open
wants to merge 11 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] res_company_search_view: Migration to 18.0 #751

wants to merge 11 commits into from
+830 −0

Conversation

HeliconiaSolutions
Copy link

No description provided.

legalsylvain and others added 10 commits December 26, 2024 16:44
@legalsylvain @HeliconiaSolutions
[ADD] res_company_search_view
22b8b26
@HeliconiaSolutions
[UPD] Update res_company_search_view.pot
dca5a81
@OCA-git-bot @HeliconiaSolutions
[UPD] README.rst
34c54d1
@OCA-git-bot @HeliconiaSolutions
[ADD] icon.png
1f923e1
@OCA-git-bot @HeliconiaSolutions
[UPD] README.rst
6903285
@Ivorra78 @HeliconiaSolutions
Added translation using Weblate (Spanish)
5df3aeb
@Ivorra78 @HeliconiaSolutions
Translated using Weblate (Spanish)
99b1cf2 
Currently translated at 100.0% (3 of 3 strings)

Translation: multi-company-16.0/multi-company-16.0-res_company_search_view
Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-res_company_search_view/es/
@mymage @HeliconiaSolutions
Added translation using Weblate (Italian)
6561c1a
@mymage @HeliconiaSolutions
Translated using Weblate (Italian)
b1dfb64 
Currently translated at 100.0% (3 of 3 strings)

Translation: multi-company-16.0/multi-company-16.0-res_company_search_view
Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-res_company_search_view/it/
@HeliconiaSolutions
[IMP] res_company_search_view: pre-commit auto fixes
f6306ed
@HeliconiaSolutions HeliconiaSolutions mentioned this pull request Dec 26, 2024
Open
@amh-mw amh-mw mentioned this pull request Dec 28, 2024
Closed
@HeliconiaSolutions HeliconiaSolutions mentioned this pull request Dec 30, 2024
Open
5 tasks
amh-mw
amh-mw suggested changes Jan 24, 2025
View reviewed changes
res_company_search_view/models/res_company.py Outdated
street2 = fields.Char(store=True)
zip = fields.Char(store=True)
city = fields.Char(store=True)
state_id = fields.Many2one(store=True)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these model changes necessary? Aren't these values stored on the related partner_id?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the same as @amh-mw, is there any reason to add this @HeliconiaSolutions?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Christian-RB , @amh-mw , Thank you for suggestions! It's fixed Please review.

@HeliconiaSolutions HeliconiaSolutions force-pushed the 18.0-mig-res_company_search_view branch 3 times, most recently from 3eb25bd to 925ef50 Compare January 31, 2025 11:50
amh-mw
amh-mw approved these changes Jan 31, 2025
View reviewed changes
Copy link

@amh-mw amh-mw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only. LGTM.

Christian-RB
Christian-RB suggested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@Christian-RB Christian-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there just one last thing

res_company_search_view/tests/test_res_company.py Outdated
Comment on lines 1 to 4
from odoo.tests.common import TransactionCase


class TestResCompany(TransactionCase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just saw this on https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

Use BaseCommon as base test class to reduce overhead from tracking and boost the test suite.

Suggested change
from odoo.tests.common import TransactionCase
class TestResCompany(TransactionCase):
from odoo.addons.base.tests.common import BaseCommon
class TestResCompany(BaseCommon):

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Christian-RB yes! it's Fixed.please review.

@HeliconiaSolutions HeliconiaSolutions force-pushed the 18.0-mig-res_company_search_view branch from 925ef50 to d465766 Compare February 7, 2025 11:14
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amh-mw amh-mw amh-mw approved these changes

@Christian-RB Christian-RB Christian-RB approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@HeliconiaSolutions @OCA-git-bot @amh-mw @Christian-RB @legalsylvain @Ivorra78 @mymage