-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] product_category_company: allow the company to be false in search domain #740
base: 16.0
Are you sure you want to change the base?
[16.0][IMP] product_category_company: allow the company to be false in search domain #740
Conversation
…ch domain This PR modifies the search method so that categories without company set are also returned. This is needed because without this change, product categories without company were not appearing in the product category list neither by searching.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
This PR modifies the search method so that categories without company set are also returned. This is needed because without this change, product categories without company were not appearing in the product category list neither by searching.