Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gen-addon-readme: add --keep-source-digest #588

Merged
merged 1 commit into from
Nov 12, 2023
Merged

gen-addon-readme: add --keep-source-digest #588

merged 1 commit into from
Nov 12, 2023

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Nov 11, 2023

Add an option to not change the source digest in the generated file.

Since

  • we want to generate README.rst in pre-commit,
  • the manifest is part of the source digest,
  • the manifest can change even if PR does not modify the README,

this option should help avoid merge conflicts.

@sbidoul sbidoul mentioned this pull request Nov 11, 2023
Closed
legalsylvain
legalsylvain approved these changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot !

@sbidoul sbidoul merged commit f71041f into OCA:master Nov 12, 2023
6 checks passed
@sbidoul sbidoul deleted the gen-addon-readme-keep-digest branch November 12, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@legalsylvain legalsylvain legalsylvain approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbidoul @legalsylvain @pedrobaeza @OCA-git-bot