This repository has been archived by the owner on May 16, 2024. It is now read-only.
[IMP] test_server: Patch odoo to create unlogged DB tables #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moylop260
force-pushed
the
oca-unlogged-moy
branch
from
0a2d829 to
9a9a25c
Compare
gurneyalex
suggested changes
Sep 12, 2018
|
What is the average performance boost? |
|
@moylop260 very interesting! @gurneyalex out of curiousity, what is the size of the wal director(ies) on runbot? Would it make sense to address this at the system level, ie by storing wals on a ram disk or ssd? |
luisg123v
reviewed
Sep 12, 2018
| @@ -312,6 +337,11 @@ def main(argv=None): | |||
| test_enable = str2bool(os.environ.get('TEST_ENABLE', True)) | |||
| dbtemplate = os.environ.get('MQT_TEMPLATE_DB', 'openerp_template') | |||
| database = os.environ.get('MQT_TEST_DB', 'openerp_test') | |||
| is_runbot = str2bool(os.environ.get('RUNBOT')) | |||
| is_gitlab_ci = str2bool(os.environ.get('GITLAB_CI')) | |||
| is_travis_ci = str2bool(os.environ.get('TRAVIS')) | |||
There was a problem hiding this comment.
Why do you consider travis CI?
Remember Travis CI manages its own PostgreSQL settings which may not be customized AFAIK.
There was a problem hiding this comment.
I'm not patching PostgreSQL.
I'm patching odoo to create "unlogged" tables and travis kill the build after success then IMHO It is a good site to use "unlogged" too.
There was a problem hiding this comment.
and we can see that it is working.
https://travis-ci.org/OCA/maintainer-quality-tools/jobs/427705355#L831-L833
This commit causes Odoo to be patched so all database tables are created as unlogged. This is applied only for testing instances because, if a docker container is stopped without firstly saving the changes, all records will be deleted; so it's not suitable for working under other environments, e.g. locally. This is compatible with the odoo versions >=7.0. Co-authored-by: Luis González <[email protected]>
luisg123v
force-pushed
the
oca-unlogged-moy
branch
from
9a9a25c to
9c81d6e
Compare
|
@sbidoul probably default values. These are handled by travis2docker and
the Vauxoo's docker stack for the image in which the runbot spawned
instances are run.
Le mer. 12 sept. 2018 à 10:09, Stéphane Bidoul (ACSONE) <
[email protected]> a écrit :
… @moylop260 <https://github.com/moylop260> very interesting!
@gurneyalex <https://github.com/gurneyalex> out of curiousity, what is
the size of the wal director(ies) on runbot? Would it make sense to address
this at the system level, ie by storing wals on a ram disk or ssd?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#573 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB8Ep69I7TTDfavNJeSwrC0r9lfZv9I8ks5uaMFEgaJpZM4WkoVh>
.
--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 58 48 20 30
Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit causes Odoo to be patched so all database tables are created
as unlogged.
Disadvantage:
If a container is stopped without stop postgresql service then the data will be corrupted... but for the case of runbot currently if a container is stopped then the build is killed too. Then this is not a real disadvantage for that environment.
This is compatible with the odoo versions >=7.0.
Co-authored by: Luis González (luisg123v)