[18.0][FIX] mail_outbound_static: Use the function formataddr() from odoo.tools instead of email.utils. #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BT-fgarbely
changed the title
BT-fgarbely
force-pushed
the
18.0-fix-formataddr
branch
from
66b7bf9 to
b43cb53
Compare
…ools instead of email.utils.
BT-fgarbely
force-pushed
the
18.0-fix-formataddr
branch
from
b43cb53 to
26c6cad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the function
formataddr()fromemail.utilshas been used.This leads to a problem if the sender's name contains at least one comma and at least one special character (e.g.
ü).Simplified example:
formataddr('Schmid, Jürgen', '[email protected]')results inSchmid, Jürgen <[email protected]>.That's wrong, because the mail servers interpret it as multiple addresses.
Now, we can use the function
formataddr()fromodoo.tools.The same example:
formataddr('Schmid, Jürgen', '[email protected]')results in"Schmid, Jürgen" <[email protected]>.That's correct.