Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][FIX] l10n_es_ticketbai - corregido filtered para no enviar rec… #2229

Merged
merged 1 commit into from
May 3, 2022
Merged

[11.0][FIX] l10n_es_ticketbai - corregido filtered para no enviar rec… #2229

merged 1 commit into from
May 3, 2022

Conversation

enriquemartin
Copy link
Contributor

…tificativas de proveedor como factura tbai.

Bug reportado por Iñaki Moral - Albokasoft

@OCA-git-bot
Copy link
Contributor

Hi @ljsalvatierra-binovo,
some modules you are maintaining are being modified, check this out!

@enriquemartin enriquemartin force-pushed the 11.0-fix-l10n_es_ticketbai-filtered_refund branch from 157ae06 to e3a4ba6 Compare April 19, 2022 10:52
@enriquemartin enriquemartin force-pushed the 11.0-fix-l10n_es_ticketbai-filtered_refund branch from e3a4ba6 to 527e3e8 Compare April 19, 2022 11:01
ao-landoo
ao-landoo approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@ao-landoo ao-landoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprobación técnica y funcional

@ao-landoo
Copy link
Contributor

@pedrobaeza Se puede mergear este PR?

@pedrobaeza pedrobaeza added this to the 11.0 milestone Apr 28, 2022
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 11.0-ocabot-merge-pr-2229-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 28, 2022
@OCA-git-bot
Merge PR #2229 into 11.0
654f2c2 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-2229-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

Pues parece haber un problema en el CI en una versión tan vieja como es ésta, y yo ya no trabajo desde hace mucho con ella, por lo que no tengo un incentivo para arreglar dicho problema de compatibilidades con la cadena de calidad, pero tampoco podemos fusionarlo en rojo, porque eso podría introducir problemas futuros. Los que queréis mantener esta versión, debéis encargaros de buscar la solución al CI.

@jfernandez-busman
Copy link

Hola @pedrobaeza .

He hecho un fork del repo de este PR. Como parece que falla en la parte de pip install -q QUnitSuite, he revisado esa librería de python y parece que actualmente no está disponible en pypi. He hecho un fork del maintainer-quality-tools, comentando esa línea en travis_install_nightly donde instala QUnitSuite y me salen OK todos los test en otra instancia de TravisCI.

¿Sería adecuado abrir un PR al repo de maintainer-quality-tools para eliminar/comentar esa línea? Imagino que esa parte falla sistemáticamente, pero consulto porque desconozco los posibles problemas que pueda acarrear. Gracias!

@pedrobaeza
Copy link
Member

pedrobaeza commented Apr 29, 2022 •
edited
Loading

Ya se ha abierto el melón sobre este problema en (EDIT) OCA/maintainer-quality-tools#704. Esa librería se usa para hacer tests de componentes del interfaz. No es lo habitual, pero podría haber alguno.

@jfernandez-busman
Copy link

Hola @pedrobaeza, he actualizado la incidencia de OCA/maintainer-quality-tools#704 y he probado a restaurar la línea de QUnitSuite en local. Parece que las pruebas están OK. No sé si podemos volver a intentar el merge. Gracias!

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 11.0-ocabot-merge-pr-2229-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 11634ad into OCA:11.0 May 3, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 249fa9c. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza mentioned this pull request May 3, 2022
Closed
@enriquemartin enriquemartin deleted the 11.0-fix-l10n_es_ticketbai-filtered_refund branch September 28, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfernandez-busman jfernandez-busman jfernandez-busman approved these changes

@ao-landoo ao-landoo ao-landoo approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@enriquemartin @OCA-git-bot @ao-landoo @pedrobaeza @jfernandez-busman