[IMP] l10n_it_fatturapa: fix access to fatturapa.attachments #4447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
aleuffre
reviewed
Nov 22, 2024
Comment on lines
7
to
13
| @api.model | ||
| def create(self, values): | ||
| attachments = super().create(values) | ||
| for att in attachments: | ||
| att.write({"res_model": self._name, "res_id": att.id}) | ||
|
|
||
| return attachments |
There was a problem hiding this comment.
question: questo fix non andrebbe direttamente nel modulo l10n_it_fatturapa?
There was a problem hiding this comment.
Grazie per la review, dovrei aver cambiato
There was a problem hiding this comment.
Credo che se si sposta la modifica al codice andrebbe spostata anche la migrazione per coerenza.
toita86
force-pushed
the
14.0-IMP-l10n_it_fatturapa_out-G-toita86
branch
2 times, most recently
from
0b229c9 to
f39b5fb
Compare
toita86
force-pushed
the
14.0-IMP-l10n_it_fatturapa_out-G-toita86
branch
from
f39b5fb to
4194bc8
Compare
|
@OCA/local-italy-maintainers buona per il merge? |
francesco-ooops
changed the title
|
Chiudo questa PR in favore di #4463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.