Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] add ability to set intrastat only for in_ or out_ invoices in l10n_it_intrastat #4256

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[14.0][IMP] add ability to set intrastat only for in_ or out_ invoices in l10n_it_intrastat #4256

wants to merge 1 commit into from

Conversation

sergiocorato
Copy link
Contributor

No description provided.

@sergiocorato sergiocorato mentioned this pull request Jul 9, 2024
Open
2 tasks
@sergiocorato sergiocorato linked an issue Jul 9, 2024 that may be closed by this pull request
l10n_it_intrastat non è possibile distinguere nella posizione fiscale se l'intrastat è obbligatorio solo per le vendite o gli acquisti #4257
Open
2 tasks
@sergiocorato sergiocorato force-pushed the 14.0-imp-l10n_it_intrastat-add-option-by-move-type branch 2 times, most recently from f3b5e08 to 6380399 Compare July 9, 2024 15:19
MaurizioPellegrinet
MaurizioPellegrinet approved these changes Jul 9, 2024
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test funzionale: OK

@sergiocorato sergiocorato force-pushed the 14.0-imp-l10n_it_intrastat-add-option-by-move-type branch 3 times, most recently from 027bfe1 to fe86928 Compare July 10, 2024 06:58
@sergiocorato
Copy link
Contributor Author

Test funzionale: OK

Grazie, ho fatto delle ulteriori modifiche per un discorso funzionale: ho rimosso il campo Intrastat generico e lasciato solo i due nuovi campi, così che sia chiaro all'utente di cosa sta impostando.
Ho aggiunto uno script di migrazione che va a settare a True i due nuovi campi quando il campo Intrastat è impostato.

MaurizioPellegrinet
MaurizioPellegrinet approved these changes Jul 10, 2024
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conferma alle modifiche: OK

@sergiocorato sergiocorato force-pushed the 14.0-imp-l10n_it_intrastat-add-option-by-move-type branch from fe86928 to 53b8fd7 Compare July 10, 2024 12:22
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 10, 2024
SirAionTech
SirAionTech requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Ho fatto revisione del codice e provato la migrazione, che però è da modificare perché la versione 14.0.1.4.3 è stata assegnata nel frattempo; quindi
/ocabot rebase

l10n_it_intrastat/models/account.py Outdated Show resolved Hide resolved
l10n_it_intrastat/models/account.py Outdated Show resolved Hide resolved
l10n_it_intrastat/models/account.py Outdated Show resolved Hide resolved
l10n_it_intrastat/views/account.xml Show resolved Hide resolved
l10n_it_intrastat/tests/test_intrastat.py Outdated Show resolved Hide resolved
l10n_it_intrastat/migrations/14.0.1.4.3/pre-migrate.py Outdated Show resolved Hide resolved
@OCA-git-bot
Copy link
Contributor

@SirAionTech The rebase process failed, because command git push --force efatto tmp-pr-4256:14.0-imp-l10n_it_intrastat-add-option-by-move-type failed with output:

remote: Permission to efatto/l10n-italy.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/efatto/l10n-italy/': The requested URL returned error: 403

1 similar comment
@OCA-git-bot
Copy link
Contributor

@SirAionTech The rebase process failed, because command git push --force efatto tmp-pr-4256:14.0-imp-l10n_it_intrastat-add-option-by-move-type failed with output:

remote: Permission to efatto/l10n-italy.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/efatto/l10n-italy/': The requested URL returned error: 403

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 17, 2024
@sergiocorato sergiocorato force-pushed the 14.0-imp-l10n_it_intrastat-add-option-by-move-type branch 3 times, most recently from b7dd497 to 2a0a5fd Compare November 22, 2024 17:14
@sergiocorato sergiocorato force-pushed the 14.0-imp-l10n_it_intrastat-add-option-by-move-type branch 2 times, most recently from f5e4add to 1694d65 Compare November 22, 2024 17:19
@sergiocorato sergiocorato force-pushed the 14.0-imp-l10n_it_intrastat-add-option-by-move-type branch from 1694d65 to c5950a2 Compare November 25, 2024 07:57
SirAionTech
SirAionTech approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fatta revisione del codice, provata la migrazione e il funzionamento: per me è ok.

Puoi correggere il messaggio del commit? Ti è scappata una y all'inizio:
image

Potresti anche seguire il formato [TAG] module: title indicato nelle linee guida https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message?

[FIX] website: remove unused alert div

Così la storia dei commit risulta più omogenea

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirAionTech SirAionTech SirAionTech approved these changes

@MaurizioPellegrinet MaurizioPellegrinet MaurizioPellegrinet approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
4 participants
@sergiocorato @OCA-git-bot @MaurizioPellegrinet @SirAionTech