Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] l10n_it_declaration_of_intent: improve date description and positioning #4227

Merged
merged 1 commit into from
Jul 10, 2024
Merged

[FIX] l10n_it_declaration_of_intent: improve date description and positioning #4227

merged 1 commit into from
Jul 10, 2024

Conversation

TheMule71
Copy link
Contributor

Backporting di #4198

@TheMule71 TheMule71 requested a review from sergiocorato June 25, 2024 09:55
@tafaRU
Copy link
Member

tafaRU commented Jun 28, 2024

@francesco-ooops curiosità: come mai no issue needed ?

@francesco-ooops
Copy link
Contributor

@tafaRU la uso saltuariamente quando una PR senza issue è stata già mergiata per l'altra versione, è una piccola modifica ed indicativamente è chiaro dalla PR cosa si va a cambiare

oppure quando è una PR che va a modificare un problema presente in una singola versione

@francesco-ooops
Copy link
Contributor

@sergiocorato buona anche per la 14?

MaurizioPellegrinet
MaurizioPellegrinet approved these changes Jul 10, 2024
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-4227-by-francesco-ooops-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 63e6c2b into OCA:14.0 Jul 10, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d8c65bb. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaurizioPellegrinet MaurizioPellegrinet MaurizioPellegrinet approved these changes

@tafaRU tafaRU tafaRU approved these changes

@sergiocorato sergiocorato Awaiting requested review from sergiocorato

Assignees
No one assigned
Labels
14.0 approved enhancement merged 🎉 no issue needed ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheMule71 @tafaRU @francesco-ooops @OCA-git-bot @MaurizioPellegrinet